Merged
Conversation
Not fully stable
- Independent of requested frequency
Ferni41359
requested changes
Mar 4, 2026
Collaborator
Ferni41359
left a comment
There was a problem hiding this comment.
Meaningless coding style and some suggestions you may like
projects/FSK_Communication/FSK_RX/FSK_RX_MATLAB/FSK_RX_MATLAB.m
Outdated
Show resolved
Hide resolved
projects/FSK_Communication/FSK_RX/FSK_RX_MATLAB/FSK_RX_MATLAB.m
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
styling is always meaningful |
Ferni41359
reviewed
Mar 5, 2026
projects/FSK_Communication/FSK_RX/FSK_RX_MATLAB/decode_fsk_message.m
Outdated
Show resolved
Hide resolved
Ferni41359
reviewed
Mar 5, 2026
Ferni41359
reviewed
Mar 5, 2026
projects/FSK_Communication/FSK_RX/FSK_RX_MATLAB/decode_fsk_message.m
Outdated
Show resolved
Hide resolved
Ferni41359
reviewed
Mar 5, 2026
Ferni41359
reviewed
Mar 5, 2026
Collaborator
Ferni41359
left a comment
There was a problem hiding this comment.
I found more, sorry I didnt notice first time. Amazing job :)
projects/FSK_Communication/FSK_RX/FSK_RX_MATLAB/decode_fsk_message.m
Outdated
Show resolved
Hide resolved
projects/FSK_Communication/FSK_RX/FSK_RX_MATLAB/decode_fsk_message.m
Outdated
Show resolved
Hide resolved
projects/FSK_Communication/FSK_RX/FSK_RX_MATLAB/decode_fsk_message.m
Outdated
Show resolved
Hide resolved
projects/FSK_Communication/FSK_RX/FSK_RX_MATLAB/decode_fsk_message.m
Outdated
Show resolved
Hide resolved
Ferni41359
approved these changes
Mar 5, 2026
Collaborator
Ferni41359
left a comment
There was a problem hiding this comment.
I don't think there is anything left. Thank you so much <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link related open issue
resolves [TASK] FSK Stability Revamp #84
Provide a short description
Provides stable MATLAB implementation
Provide a more detailed list of changes
Does this PR introduce a breaking change?
N/A
Other information
N/A