Skip to content

Feature: Support independent timers for ADCs enabling different sampling rates#26

Merged
fanfare-ff merged 12 commits intoShiegeChan:mainfrom
LorenzoBuldorini:feature/independent-adc-sampling
Nov 7, 2025
Merged

Feature: Support independent timers for ADCs enabling different sampling rates#26
fanfare-ff merged 12 commits intoShiegeChan:mainfrom
LorenzoBuldorini:feature/independent-adc-sampling

Conversation

@LorenzoBuldorini
Copy link
Collaborator

@LorenzoBuldorini LorenzoBuldorini commented Oct 15, 2025

  • ADCs are no longer tied to a single timer (TIM1)
  • Separate timers for ADC1 (TIM1), ADC2 (TIM3), and ADC3 (TIM6) to allow different sampling rates for each ADC
  • New SensEdu library example Test_SR_3ADC_3Tim to demonstrate the new feature

@fanfare-ff fanfare-ff self-requested a review October 15, 2025 12:37
@fanfare-ff fanfare-ff self-assigned this Oct 15, 2025
Copy link
Collaborator

@fanfare-ff fanfare-ff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @LorenzoBuldorini, we are happy to have your support on the project :)
I’ve reviewed the changes and added a couple of suggestions.
Thank you for your contribution!

@fanfare-ff fanfare-ff linked an issue Oct 15, 2025 that may be closed by this pull request
3 tasks
@fanfare-ff fanfare-ff self-requested a review October 21, 2025 15:32
@fanfare-ff fanfare-ff changed the title Feature: Support independent timers for ADCs with different sampling rate Feature: Support independent timers for ADCs enabling different sampling rates Oct 21, 2025
Copy link
Collaborator

@fanfare-ff fanfare-ff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the example works fine. I made some minor improvement suggestions, please look into them. Other than that the PR is ready to be merged.

Copy link
Collaborator

@fanfare-ff fanfare-ff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@fanfare-ff fanfare-ff requested a review from svire-at November 7, 2025 13:41
Copy link
Collaborator

@svire-at svire-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fanfare-ff fanfare-ff merged commit 72f7c26 into ShiegeChan:main Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate Timers for ADCs

3 participants