Skip to content

Conversation

@Shane32
Copy link
Owner

@Shane32 Shane32 commented Apr 13, 2025

Prerequisites (to reduce diff):

Status:

  • All generated micro QR codes are scannable
  • Most QR codes match the output of the segno python library
  • Need to add tests and validate combinations of lengths, character types, etc

Side notes:

  • ASCII small generator has x/y swapped and prints inverted compared to regular ASCII generator
  • The segno python library does not apply padding properly so micro QR codes consisting mostly of padding don't match

@Shane32
Copy link
Owner Author

Shane32 commented Apr 14, 2025

M2 codes will generate correctly now

@Shane32
Copy link
Owner Author

Shane32 commented Apr 16, 2025

Still a little more work to do, but it appears to be generating readable codes for all micro QR code sizes now.

@Shane32 Shane32 marked this pull request as ready for review April 19, 2025 15:30
@Shane32
Copy link
Owner Author

Shane32 commented Apr 19, 2025

This implementation is complete. I might add some more tests but everything is working.

@gfoidl
Copy link
Collaborator

gfoidl commented Apr 23, 2025

I'm looking forward to review the PR, but after #590 got merged so I can focus on the new stuff.

@Shane32 👍🏻 for your work

@codebude
Copy link
Collaborator

codebude commented Jun 2, 2025

@gfoidl #590 is merged now.

@Shane32
Copy link
Owner Author

Shane32 commented Sep 30, 2025

This PR includes changes within #596 --- recommend to merge #596 first

@codebude codebude merged commit 4f546a6 into Shane32:master Sep 30, 2025
4 checks passed
@Shane32 Shane32 mentioned this pull request Sep 30, 2025
@Shane32 Shane32 added this to the 1.7.0 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants