Address more review feedback #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 17, 2021 20:08
- Add docs - IHandler => IParsingStrategy - Pass StringBuilder/statement in Parse method rather than handing it to strategy constructors (easier to follow) - Handled => GoToNextSymbol - strategies => priorityOrderedParsingStrategies to make it more clear that the order is important
- Having "WithMessage("*..*")" was causing failing tests to pass (this
seems odd, maybe WithMessage isn't working correctly?)
- note: a trailing whitespace character was auto-trimmed by my IDE, I left the change because it felt dirty :P
|
Related to fluentassertions#1435 |
added 4 commits
June 18, 2021 08:46
- This is why we added NotifyEndOfLineReached()
- Use guard clauses & extract naming variables
Author
|
I thought about a couple more edge cases this morning that should probably be covered by the tests, and while I had the IDE open I applied a couple more cleanups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Serg046 Thanks for merging the last one so quickly!
I have a new round of changes ready to go, I'd love it if you could merge again (bonus gratitude if you take a look)
Cheers!