Ports: Add initial Pipe Viewer (pv) 1.6.20 port#10916
Merged
linusg merged 2 commits intoSerenityOS:masterfrom Nov 14, 2021
Merged
Ports: Add initial Pipe Viewer (pv) 1.6.20 port#10916linusg merged 2 commits intoSerenityOS:masterfrom
linusg merged 2 commits intoSerenityOS:masterfrom
Conversation
Previously if code attempted to use the format specifier somewhere (Ex: "%#4.3Lg"), the specifier would get dropped and we would just print "g" instead of any value. Now at least we print a value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this article on optimizing
yeswas linked in the discord, I realized it would be useful to have pipe viewer working on serenity.The name does class with profile viewer, but they are currently installed to different locations, so profile viewer will take precedent.
Maybe we should think about renaming profile viewer to
profvor something instead...