2025-04-24 gitea - master branch - PR 1 of 2#798
Merged
Slyke merged 8 commits intoSensorsIot:masterfrom May 18, 2025
Merged
Conversation
1. Updates to image which is being actively maintained. 2. Adopts environment variable conventions of new image. 3. Uses custom MariaDB instance as back-end. 4. Removes `/etc/timezone` mapping (without replacing with `TZ`) because new image is built without `tzdata`. 5. Adds basic documentation. Signed-off-by: Phill Kelley <34226495+Paraphraser@users.noreply.github.com>
Adds environment vars to support HTTPS. Adds documentation: * enabling HTTPS * migrating existing repositories Signed-off-by: Phill Kelley <34226495+Paraphraser@users.noreply.github.com>
Signed-off-by: Phill Kelley <34226495+Paraphraser@users.noreply.github.com>
Signed-off-by: Phill Kelley <34226495+Paraphraser@users.noreply.github.com>
When HTTPS was enabled, the healthcheck script failed for a number of reasons, not the least of which were `curl` needing to be provided with the path to the container's self-signed certificate and problems associated with using "localhost" rather than the container name. In theory, `gitea cert` will generate for `--host gitea,localhost` and those do turn up in the certificate. But `curl` doesn't seem to like it. Rather than try to figure out why `curl` gets upset, it's easier to just use "hostname" syntax in the healthcheck URL. In other words: ``` https://gitea:3000 ``` rather than: ``` https://localhost:3000 ``` Although it isn't strictly necessary for HTTP, I used "hostname" syntax for that URL too, for consistency. Unlike `localhost`, "hostname" syntax also steers clear of IPv6 `::1`. Documentation updated to include instructions for swapping the healthcheck URLs when enabling HTTPS. Signed-off-by: Phill Kelley <34226495+Paraphraser@users.noreply.github.com>
Using the [`CMD-SHELL`](https://docs.docker.com/reference/compose-file/services/#healthcheck) form of the `healthcheck` test allows for passing the variable **name** `GITEA__server__CERT_FILE` to the check. The `$$` prefix stops docker compose from trying to substitute the variable name at "up" time. The variable will be substituted at run time, which means it will take on the **value** of that variable as specified in the `environment` clause in the service definition. This approach will automatically keep the health check in sync with the value of the environment variable (ie reducing the likelihood of any mismatch if the user "gets creative" with certificate generation). Signed-off-by: Phill Kelley <34226495+Paraphraser@users.noreply.github.com>
Signed-off-by: Phill Kelley <34226495+Paraphraser@users.noreply.github.com>
Signed-off-by: Phill <34226495+Paraphraser@users.noreply.github.com>
Slyke
approved these changes
May 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to image which is being actively maintained.
Adopts environment variable conventions of new image.
Uses custom MariaDB instance as back-end.
Removes
/etc/timezonemapping (without replacing withTZ) because new image is built withouttzdata.Adds basic documentation.