Skip to content

2025-04-24 mariadb - master branch - PR 1 of 2#796

Merged
Slyke merged 1 commit intoSensorsIot:masterfrom
Paraphraser:20250424-mariadb-master
May 18, 2025
Merged

2025-04-24 mariadb - master branch - PR 1 of 2#796
Slyke merged 1 commit intoSensorsIot:masterfrom
Paraphraser:20250424-mariadb-master

Conversation

@Paraphraser
Copy link

  1. Dockerfile syntax deprecates ENV key value in favour of ENV key=value.

  2. Adjust health-check script to deal with two problems:

    a. An issue where MYSQL_ROOT_PASSWORD does not result in a root
    password being set on a newly-initialised database.
    See docker-mariadb issue 163

    b. Steady deprecation of mysqladmin in favour of mariadb-admin.

1. Dockerfile syntax deprecates `ENV key value` in favour of
   `ENV key=value`.

2. Adjust health-check script to deal with two problems:

	a. An issue where `MYSQL_ROOT_PASSWORD` does not result in a root
	   password being set on a newly-initialised database.
	   See [docker-mariadb issue 163](linuxserver/docker-mariadb#163)

	b. Steady deprecation of `mysqladmin` in favour of `mariadb-admin`.

Signed-off-by: Phill Kelley <34226495+Paraphraser@users.noreply.github.com>
Copy link

@Noschvie Noschvie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Slyke Slyke merged commit c2843fc into SensorsIot:master May 18, 2025
@Paraphraser Paraphraser deleted the 20250424-mariadb-master branch May 18, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants