Merged
Conversation
✅ Deploy Preview for jovial-austin-42fe02 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
8 tasks
Contributor
Author
|
This is the documentation for the new feature that was added via PR SeleniumHQ/selenium#11277 ping @diemol |
21eeb7f to
c95a45a
Compare
diemol
requested changes
Dec 14, 2022
Member
diemol
left a comment
There was a problem hiding this comment.
Thank you for raising this PR, @krmahadevan. I left a couple of comments.
website_and_docs/content/documentation/grid/configuration/cli_options.en.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/configuration/toml_options.en.md
Outdated
Show resolved
Hide resolved
c95a45a to
68af97b
Compare
nirtal85
suggested changes
Dec 15, 2022
website_and_docs/content/documentation/grid/configuration/cli_options.en.md
Show resolved
Hide resolved
Adding documentation that explains how to specify a directory from which tests can now download files that were downloaded by them on the node.
68af97b to
a77bc7e
Compare
diemol
approved these changes
Dec 19, 2022
Member
diemol
left a comment
There was a problem hiding this comment.
I am going to merge this as it is and will tweak a couple of things before publishing.
Thank you, @krmahadevan!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding documentation that explains how to specify
a directory from which tests can now download files that were downloaded by them on the node.
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Adding documentation that explains how to specify
a directory from which tests can now download files that were downloaded by them on the node.
Description
Adding documentation that explains how to specify
a directory from which tests can now download files that were downloaded by them on the node.
Motivation and Context
Types of changes
Checklist