Skip to content

Add a Window Timeout Field in the Command Editor, for Commands Marked as Opening a Window #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toddtarsi merged 1 commit into from
May 18, 2024
Merged

Add a Window Timeout Field in the Command Editor, for Commands Marked as Opening a Window #1830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/selenium-ide/src/browser/I18N/en/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,8 @@ const testCore = {
value: 'Value',
windowHandleName: 'Window Handle Name',
windowHandleNameNote: 'Variable name to set to the new window handle',
windowTimeout: 'Window Timeout',
windowTimeoutNote: 'The amount of time to wait for the window to open (in milliseconds)',
commands: 'Commands',
tabCommand: 'Cmd',
tabTarget: 'Target',
Expand Down
2 changes: 2 additions & 0 deletions packages/selenium-ide/src/browser/I18N/zh/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ const testCore = {
value: '指令值',
windowHandleName: '窗口句柄名称',
windowHandleNameNote: '要设置为新窗口句柄的变量名称',
windowTimeout: '窗口超时',
windowTimeoutNote: '等待窗口打开的时间量（以毫秒为单位）',
commands: '指令集',
tabCommand: '指令',
tabTarget: '关键字',
Expand Down
38 changes: 26 additions & 12 deletions packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Tests/TestCommandEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,18 +70,32 @@ const CommandEditor: FC<CommandEditorProps> = ({
<ArgField command={correctedCommand} {...props} fieldName="target" />
<ArgField command={correctedCommand} {...props} fieldName="value" />
{command.opensWindow && (
<CommandTextField
command={correctedCommand}
{...props}
fieldName={
intl.formatMessage({
id: languageMap.testCore.windowHandleName,
}) as 'windowHandleName'
}
note={intl.formatMessage({
id: languageMap.testCore.windowHandleNameNote,
})}
/>
<>
<CommandTextField
command={correctedCommand}
{...props}
fieldName={
intl.formatMessage({
id: languageMap.testCore.windowHandleName,
}) as 'windowHandleName'
}
note={intl.formatMessage({
id: languageMap.testCore.windowHandleNameNote,
})}
/>
<CommandTextField
command={correctedCommand}
{...props}
fieldName={
intl.formatMessage({
id: languageMap.testCore.windowTimeout,
}) as 'windowTimeout'
}
note={intl.formatMessage({
id: languageMap.testCore.windowTimeoutNote,
})}
/>
</>
)}
<CommandTextField
command={correctedCommand}
Expand Down
2 changes: 1 addition & 1 deletion packages/selenium-ide/src/browser/windows/ProjectEditor/tabs/Tests/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export interface CommandArgFieldProps extends CommandEditorProps {
}

export interface CommandFieldProps extends CommandEditorProps {
fieldName: 'comment' | 'windowHandleName' | LocatorFields
fieldName: 'comment' | 'windowHandleName' | 'windowTimeout' | LocatorFields
note?: string
}

Expand Down