[dotnet] [build] Combine bazel targets#17387
Merged
nvborisenko merged 1 commit intoApr 25, 2026
Merged
Conversation
Contributor
Review Summary by QodoConsolidate Bazel build targets for improved parallelization
WalkthroughsDescription• Consolidate three separate Bazel build targets into single unified target • Improve build parallelization by allowing Bazel to optimize target execution • Reduce build complexity and redundancy in MSBuild process • Accelerate IDE single test execution performance File Changes1. dotnet/src/webdriver/Selenium.WebDriver.csproj
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates multiple MSBuild-invoked Bazel build steps for the .NET WebDriver project into a single target, aiming to reduce redundant Bazel invocations and improve IDE/test build performance.
Changes:
- Replaced three separate MSBuild targets (
GenerateSeleniumManagerBinaries,GenerateResources,GenerateCdp) with one unifiedGenerateBazelArtifactstarget. - Updated the unified target to build all required Bazel outputs in one command and include the generated
.cssources in compilation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let
bazelparallelize targets, msbuild runsbazelonce (per target framework). Still safe. Now it is faster in IDE to "run single test".💥 What does this PR do?
This pull request simplifies and consolidates the build process in the
Selenium.WebDriver.csprojfile by merging multiple Bazel build steps into a single target. This change streamlines the generation of required build artifacts and reduces redundancy.Build process simplification:
GenerateSeleniumManagerBinaries,GenerateResources, andGenerateCdptargets with a single unifiedGenerateBazelArtifactstarget that builds all necessary Bazel artifacts before compilation. [1] [2]ResourceUtilities.g.csand DevTools code) are included in the compilation in one step, reducing complexity and potential for build errors.No other functional or code changes are included in this pull request.
🤖 AI assistance
🔄 Types of changes