• Honor full chromedriver version when explicitly specified
• Add helper method to check if driver version is specific
• Fix version filtering logic to use full version string
• Prevent unnecessary major version extraction for explicit versions

Fix chromedriver version filtering logic

• Modified request_good_driver_version_from_online() to check if driver version is explicitly
 specified
• When driver version is specific, use it directly without extracting major version
• Updated version filtering to use string reference instead of owned string
• Improved logic flow to distinguish between explicit and inferred versions

rust/src/chrome.rs

Add driver version specificity check method

• Added new is_driver_version_specific() method to SeleniumManager trait
• Method checks if driver version contains dots (indicating specific version)
• Mirrors existing is_browser_version_specific() pattern

rust/src/lib.rs

Description

The driver-version selection logic for Chrome now changes behavior by filtering on the full driver
version when it is version-specific, but there is no positive test asserting this observable
behavior. This risks regressions where Selenium Manager again downloads a different chromedriver
version than the one specified.

Code

rust/src/chrome.rs[R174-186]

+        let version_for_filtering = if self.is_driver_version_specific() {
            self.get_driver_version()
+        } else {
+            let browser_or_driver_version = if self.get_driver_version().is_empty() {
+                self.get_browser_version()
+            } else {
+                self.get_driver_version()
+            };
+            &self.get_major_version(browser_or_driver_version)?
        };
-        let version_for_filtering = self.get_major_version(browser_or_driver_version)?;
        self.log.trace(format!(
            "Driver version used to request CfT: {version_for_filtering}"
        ));

Evidence

PR Compliance ID 9 requires adding/updating unit tests for observable behavior changes. The change
in request_good_driver_version_from_online() alters how chromedriver versions are
filtered/selected (full version vs major), while existing integration tests exercise Chrome with
--browser-version or only validate error handling for --driver-version, not successful Chrome
--driver-version resolution.

rust/src/chrome.rs[174-195]
rust/tests/browser_tests.rs[27-95]
Best Practice: Learned patterns

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Chrome now honors a fully specified chromedriver version by filtering known-good versions using the full version string. This is an observable behavior change but there is no test that asserts successful resolution/download selection for Chrome when `--driver-version` is provided.

## Issue Context
The change is in `ChromeManager::request_good_driver_version_from_online()`, which now uses `is_driver_version_specific()` to decide whether to filter by the full driver version vs the major version.

## Fix Focus Areas
- rust/src/chrome.rs[174-195]
- rust/src/lib.rs[819-821]
- rust/tests/browser_tests.rs[27-95]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Description

ChromeManager::request_good_driver_version_from_online can set version_for_filtering to a
reference to the temporary String returned by get_major_version(), which is dropped at the end
of the if expression and fails to compile. Additionally, `format_three_args(...,
&version_for_filtering, ...) now passes &&str because version_for_filtering` is inferred as
&str, causing another compile-time type mismatch.

Code

rust/src/chrome.rs[R174-186]

+        let version_for_filtering = if self.is_driver_version_specific() {
            self.get_driver_version()
+        } else {
+            let browser_or_driver_version = if self.get_driver_version().is_empty() {
+                self.get_browser_version()
+            } else {
+                self.get_driver_version()
+            };
+            &self.get_major_version(browser_or_driver_version)?
        };
-        let version_for_filtering = self.get_major_version(browser_or_driver_version)?;
        self.log.trace(format!(
            "Driver version used to request CfT: {version_for_filtering}"
        ));

Evidence

get_driver_version() returns &str, so the if expression forces version_for_filtering to be
&str. In the else branch you borrow the temporary String returned by get_major_version()
(&self.get_major_version(...)), which cannot outlive the if expression. Separately,
format_three_args requires &str arguments, but &version_for_filtering becomes &&str once
version_for_filtering: &str.

rust/src/chrome.rs[173-203]
rust/src/lib.rs[1087-1089]
rust/src/lib.rs[1380-1382]
rust/src/lib.rs[1745-1749]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`version_for_filtering` is inferred as `&str` (because `get_driver_version()` returns `&str`), but the `else` branch returns `&self.get_major_version(...)` where `get_major_version` returns a fresh `String`. This creates a reference to a temporary and fails compilation. Also, `format_three_args(..., &version_for_filtering, ...)` now passes `&&str`.

### Issue Context
You need `version_for_filtering` to live long enough for logging/filtering/error formatting. The simplest fix is to make it an owned `String` in both branches.

### Fix Focus Areas
- rust/src/chrome.rs[173-203]

### Suggested change
- Change `version_for_filtering` to be a `String`:
 - `if self.is_driver_version_specific() { self.get_driver_version().to_string() } else { self.get_major_version(browser_or_driver_version)? }`
- Update usage sites:
 - `starts_with(version_for_filtering.as_str())`
 - `format_three_args(..., version_for_filtering.as_str(), ...)` (remove the extra `&`)

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools