[dotnet] [bidi] Add SetScrollbarTypeOverride command in Emulation module by nvborisenko · Pull Request #17171 · SeleniumHQ/selenium

nvborisenko · 2026-03-03T18:20:55Z

https://w3c.github.io/webdriver-bidi/#command-emulation-setScrollbarTypeOverride

💥 What does this PR do?

Adds support for overriding the scrollbar type in the BiDi Emulation module. The main changes include the introduction of new command and result types, updates to the emulation interface and implementation, and new tests to verify the functionality.

🔄 Types of changes

New feature (non-breaking change which adds functionality and tests!)

qodo-code-review · 2026-03-03T18:21:09Z

Review Summary by Qodo

Add SetScrollbarTypeOverride command to BiDi Emulation module

✨ Enhancement

Walkthroughs

Description

• Adds SetScrollbarTypeOverride command to BiDi Emulation module
• Introduces ScrollbarType enum with Classic and Overlay options
• Implements command, parameters, options, and result types
• Adds comprehensive unit tests for the new functionality

File Changes

1. dotnet/src/webdriver/BiDi/Emulation/SetScrollbarTypeOverrideCommand.cs ✨ Enhancement +44/-0

New SetScrollbarTypeOverride command implementation

• New file implementing SetScrollbarTypeOverrideCommand class
• Defines SetScrollbarTypeOverrideParameters record with ScrollbarType, Contexts, and UserContexts
• Introduces ScrollbarType enum with Classic and Overlay values
• Creates SetScrollbarTypeOverrideOptions and SetScrollbarTypeOverrideResult types

dotnet/src/webdriver/BiDi/Emulation/SetScrollbarTypeOverrideCommand.cs

2. dotnet/src/webdriver/BiDi/Emulation/EmulationModule.cs ✨ Enhancement +9/-0

Add SetScrollbarTypeOverride method to module

• Adds SetScrollbarTypeOverrideAsync method to EmulationModule class
• Registers SetScrollbarTypeOverrideCommand and SetScrollbarTypeOverrideResult for JSON
 serialization
• Follows existing pattern for emulation command execution

dotnet/src/webdriver/BiDi/Emulation/EmulationModule.cs

3. dotnet/src/webdriver/BiDi/Emulation/IEmulationModule.cs ✨ Enhancement +1/-0

Add SetScrollbarTypeOverride interface method
• Adds SetScrollbarTypeOverrideAsync method signature to IEmulationModule interface
• Maintains alphabetical ordering of interface methods
dotnet/src/webdriver/BiDi/Emulation/IEmulationModule.cs

View more (1)

4. dotnet/test/common/BiDi/Emulation/EmulationTests.cs 🧪 Tests +20/-0

Add SetScrollbarTypeOverride unit tests
• Adds CanSetScrollbarTypeOverride test with Overlay scrollbar type
• Adds CanSetScrollbarTypeOverrideToDefault test with null parameter
• Tests both explicit and default override scenarios
dotnet/test/common/BiDi/Emulation/EmulationTests.cs

qodo-code-review · 2026-03-03T18:21:10Z

Code Review by Qodo

🐞 Bugs (4) 📘 Rule violations (3) 📎 Requirement gaps (0)

1. New IEmulationModule method 📘 Rule violation ✓ Correctness

Description

A new member was added to the public IEmulationModule interface, which is a breaking API/ABI
change for any downstream implementations of that interface. Existing consumers implementing
IEmulationModule will fail to compile (and may fail at runtime depending on binding/dispatch).

Code

dotnet/src/webdriver/BiDi/Emulation/IEmulationModule.cs[32]

+    Task<SetScrollbarTypeOverrideResult> SetScrollbarTypeOverrideAsync(ScrollbarType? scrollbarType, SetScrollbarTypeOverrideOptions? options = null, CancellationToken cancellationToken = default);

Evidence

PR Compliance ID 1 requires preserving public API/ABI compatibility. The PR adds
SetScrollbarTypeOverrideAsync(...) to the public IEmulationModule interface, which breaks
downstream implementers by introducing a new required member.

AGENTS.md
dotnet/src/webdriver/BiDi/Emulation/IEmulationModule.cs[22-33]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A new method was added to the public `IEmulationModule` interface, which is a breaking change for downstream implementers and violates API/ABI compatibility expectations.
## Issue Context
Downstream projects may implement `IEmulationModule`. Adding a new interface member forces them to update implementations, meaning they cannot upgrade by changing only the version number.
## Fix Focus Areas
- dotnet/src/webdriver/BiDi/Emulation/IEmulationModule.cs[22-33]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. New IEmulationModule method 📘 Rule violation ✓ Correctness

Description

A new member was added to the public IEmulationModule interface, which is a breaking API/ABI
change for any downstream implementations of that interface. Existing consumers implementing
IEmulationModule will fail to compile (and may fail at runtime depending on binding/dispatch).

Code

dotnet/src/webdriver/BiDi/Emulation/IEmulationModule.cs[32]

+    Task<SetScrollbarTypeOverrideResult> SetScrollbarTypeOverrideAsync(ScrollbarType? scrollbarType, SetScrollbarTypeOverrideOptions? options = null, CancellationToken cancellationToken = default);

Evidence

PR Compliance ID 1 requires preserving public API/ABI compatibility. The PR adds
SetScrollbarTypeOverrideAsync(...) to the public IEmulationModule interface, which breaks
downstream implementers by introducing a new required member.

AGENTS.md
dotnet/src/webdriver/BiDi/Emulation/IEmulationModule.cs[22-33]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A new method was added to the public `IEmulationModule` interface, which is a breaking change for downstream implementers and violates API/ABI compatibility expectations.
## Issue Context
Downstream projects may implement `IEmulationModule`. Adding a new interface member forces them to update implementations, meaning they cannot upgrade by changing only the version number.
## Fix Focus Areas
- dotnet/src/webdriver/BiDi/Emulation/IEmulationModule.cs[22-33]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

3. ~~Ungated new BiDi test~~ ☑ 🐞 Bug ⛯ Reliability

Description

The new SetScrollbarTypeOverride tests run on all configured browsers without any feature-gating.
If a given browser/driver doesn’t implement emulation.setScrollbarTypeOverride yet, these tests
will fail and block CI even though the binding code is correct.

Code

dotnet/test/common/BiDi/Emulation/EmulationTests.cs[R134-152]

+    [Test]
+    public void CanSetScrollbarTypeOverride()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(ScrollbarType.Overlay, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }
+
+    [Test]
+    public void CanSetScrollbarTypeOverrideToDefault()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(null, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }

Evidence
The newly added tests are unconditional (no IgnoreBrowser) while other emulation override tests in
the same file explicitly use IgnoreBrowser when commands are not supported yet. The IgnoreBrowser
mechanism keys off EnvironmentManager.Instance.Browser, and the BiDi fixture creates a driver
based on that environment; therefore, without gating, the new tests will execute on whichever
browser is configured and fail if unsupported. Additionally, broker error responses are surfaced as
BiDiException, which could be used for feature-detection-based skipping if desired.
dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-152]
dotnet/test/common/BiDi/Emulation/EmulationTests.cs[86-110]
dotnet/test/common/CustomTestAttributes/IgnoreBrowserAttribute.cs[28-75]
dotnet/test/common/BiDi/BiDiFixture.cs[24-50]
dotnet/src/webdriver/BiDi/Broker.cs[224-230]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new scrollbar override tests run unconditionally. In environments where the underlying browser/driver doesn’t support `emulation.setScrollbarTypeOverride` yet, they can fail CI even though the client binding is correct.
### Issue Context
This test suite already uses `IgnoreBrowser` to avoid running unsupported BiDi commands on specific browsers.
### Fix Focus Areas
- dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-152]
- dotnet/test/common/BiDi/Emulation/EmulationTests.cs[86-110]
- dotnet/test/common/CustomTestAttributes/IgnoreBrowserAttribute.cs[28-75]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

4. Scrollbar tests always ignored 📘 Rule violation ⛯ Reliability

Description

The newly added tests for scrollbar override are ignored for Chrome, Edge, and Firefox, so they do
not provide effective coverage in CI. This undermines the requirement to include appropriate tests
for behavioral changes.

Code

dotnet/test/common/BiDi/Emulation/EmulationTests.cs[R134-158]

+    [Test]
+    [IgnoreBrowser(Selenium.Browser.Chrome, "Not supported yet?")]
+    [IgnoreBrowser(Selenium.Browser.Edge, "Not supported yet?")]
+    [IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
+    public void CanSetScrollbarTypeOverride()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(ScrollbarType.Overlay, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }
+
+    [Test]
+    [IgnoreBrowser(Selenium.Browser.Chrome, "Not supported yet?")]
+    [IgnoreBrowser(Selenium.Browser.Edge, "Not supported yet?")]
+    [IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
+    public void CanSetScrollbarTypeOverrideToDefault()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(null, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }

Evidence

PR Compliance ID 4 requires adding/updating tests when feasible. The added tests are explicitly
ignored on the major supported browsers, meaning the feature is effectively untested by these
additions.

AGENTS.md
dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-158]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The added tests for the new scrollbar override command are ignored for Chrome/Edge/Firefox, so they do not provide effective CI coverage.
## Issue Context
The compliance requirement expects tests for behavioral changes when feasible, preferring small/unit tests. If browser support is not available yet, a unit/serialization test can still validate the command payload and enum conversion.
## Fix Focus Areas
- dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-158]
- dotnet/src/webdriver/BiDi/Emulation/SetScrollbarTypeOverrideCommand.cs[25-44]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

5. ~~Ungated new BiDi test~~ ☑ 🐞 Bug ⛯ Reliability

Description

The new SetScrollbarTypeOverride tests run on all configured browsers without any feature-gating.
If a given browser/driver doesn’t implement emulation.setScrollbarTypeOverride yet, these tests
will fail and block CI even though the binding code is correct.

Code

dotnet/test/common/BiDi/Emulation/EmulationTests.cs[R134-152]

+    [Test]
+    public void CanSetScrollbarTypeOverride()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(ScrollbarType.Overlay, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }
+
+    [Test]
+    public void CanSetScrollbarTypeOverrideToDefault()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(null, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }

Evidence
The newly added tests are unconditional (no IgnoreBrowser) while other emulation override tests in
the same file explicitly use IgnoreBrowser when commands are not supported yet. The IgnoreBrowser
mechanism keys off EnvironmentManager.Instance.Browser, and the BiDi fixture creates a driver
based on that environment; therefore, without gating, the new tests will execute on whichever
browser is configured and fail if unsupported. Additionally, broker error responses are surfaced as
BiDiException, which could be used for feature-detection-based skipping if desired.
dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-152]
dotnet/test/common/BiDi/Emulation/EmulationTests.cs[86-110]
dotnet/test/common/CustomTestAttributes/IgnoreBrowserAttribute.cs[28-75]
dotnet/test/common/BiDi/BiDiFixture.cs[24-50]
dotnet/src/webdriver/BiDi/Broker.cs[224-230]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new scrollbar override tests run unconditionally. In environments where the underlying browser/driver doesn’t support `emulation.setScrollbarTypeOverride` yet, they can fail CI even though the client binding is correct.
### Issue Context
This test suite already uses `IgnoreBrowser` to avoid running unsupported BiDi commands on specific browsers.
### Fix Focus Areas
- dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-152]
- dotnet/test/common/BiDi/Emulation/EmulationTests.cs[86-110]
- dotnet/test/common/CustomTestAttributes/IgnoreBrowserAttribute.cs[28-75]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

6. Scrollbar tests are smoke-only 🐞 Bug ⛯ Reliability

Description

The new tests only assert that the command doesn’t throw and don’t validate that scrollbar behavior
actually changed or was reset. This is consistent with other tests in this file, but it limits the
tests’ ability to catch no-op implementations/regressions.

Code

dotnet/test/common/BiDi/Emulation/EmulationTests.cs[R134-152]

+    [Test]
+    public void CanSetScrollbarTypeOverride()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(ScrollbarType.Overlay, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }
+
+    [Test]
+    public void CanSetScrollbarTypeOverrideToDefault()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(null, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }

Evidence

Both added tests only wrap the async call and assert Throws.Nothing; there are no post-conditions
asserted (e.g., computed style/visual behavior checks).

dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-152]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Current tests only verify that the command call does not throw, which may not detect cases where the command is accepted but has no effect.
### Issue Context
This file uses smoke-style assertions for multiple emulation commands; consider adding at least one higher-signal assertion specifically for scrollbar behavior if practical.
### Fix Focus Areas
- dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-152]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

7. Scrollbar tests are smoke-only 🐞 Bug ⛯ Reliability

Description

The new tests only assert that the command doesn’t throw and don’t validate that scrollbar behavior
actually changed or was reset. This is consistent with other tests in this file, but it limits the
tests’ ability to catch no-op implementations/regressions.

Code

dotnet/test/common/BiDi/Emulation/EmulationTests.cs[R134-152]

+    [Test]
+    public void CanSetScrollbarTypeOverride()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(ScrollbarType.Overlay, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }
+
+    [Test]
+    public void CanSetScrollbarTypeOverrideToDefault()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(null, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }

Evidence

Both added tests only wrap the async call and assert Throws.Nothing; there are no post-conditions
asserted (e.g., computed style/visual behavior checks).

dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-152]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Current tests only verify that the command call does not throw, which may not detect cases where the command is accepted but has no effect.
### Issue Context
This file uses smoke-style assertions for multiple emulation commands; consider adding at least one higher-signal assertion specifically for scrollbar behavior if practical.
### Fix Focus Areas
- dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-152]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

ⓘ The new review experience is currently in Beta. Learn more

Copilot

Pull request overview

This PR adds support for the emulation.setScrollbarTypeOverride WebDriver BiDi command, as defined in the W3C spec. It introduces new types and hooks them into the existing Emulation module infrastructure.

Changes:

Introduces ScrollbarType enum, SetScrollbarTypeOverrideCommand, SetScrollbarTypeOverrideParameters, SetScrollbarTypeOverrideOptions, and SetScrollbarTypeOverrideResult types
Wires up the new command in EmulationModule (implementation) and IEmulationModule (interface), including [JsonSerializable] context registration
Adds two integration tests covering setting an explicit scrollbar type and resetting to default

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
`SetScrollbarTypeOverrideCommand.cs`	New file defining command, parameters, options, result, and `ScrollbarType` enum
`EmulationModule.cs`	Adds `SetScrollbarTypeOverrideAsync` method and registers types in the JSON serializer context
`IEmulationModule.cs`	Adds `SetScrollbarTypeOverrideAsync` to the public interface
`EmulationTests.cs`	Adds `CanSetScrollbarTypeOverride` and `CanSetScrollbarTypeOverrideToDefault` integration tests

dotnet/src/webdriver/BiDi/Emulation/IEmulationModule.cs

…-type

qodo-code-review · 2026-03-11T17:35:34Z

Review Summary by Qodo

Add SetScrollbarTypeOverride command to BiDi Emulation module

✨ Enhancement

Walkthroughs

Description

• Adds SetScrollbarTypeOverride command to BiDi Emulation module
• Implements ScrollbarType enum with Classic and Overlay options
• Adds comprehensive test coverage for scrollbar override functionality
• Includes command, parameters, options, and result types

File Changes

1. dotnet/src/webdriver/BiDi/Emulation/SetScrollbarTypeOverrideCommand.cs ✨ Enhancement +44/-0

New scrollbar type override command implementation

• New file implementing SetScrollbarTypeOverrideCommand class
• Defines SetScrollbarTypeOverrideParameters record with ScrollbarType property
• Introduces ScrollbarType enum with Classic and Overlay values
• Creates SetScrollbarTypeOverrideOptions and SetScrollbarTypeOverrideResult types

dotnet/src/webdriver/BiDi/Emulation/SetScrollbarTypeOverrideCommand.cs

2. dotnet/src/webdriver/BiDi/Emulation/EmulationModule.cs ✨ Enhancement +9/-0

Add scrollbar override method to module

• Adds SetScrollbarTypeOverrideAsync method to EmulationModule class
• Registers SetScrollbarTypeOverrideCommand and SetScrollbarTypeOverrideResult for JSON
 serialization
• Follows existing pattern for emulation command execution

dotnet/src/webdriver/BiDi/Emulation/EmulationModule.cs

3. dotnet/src/webdriver/BiDi/Emulation/IEmulationModule.cs ✨ Enhancement +1/-0

Add scrollbar override to interface
• Adds SetScrollbarTypeOverrideAsync method signature to IEmulationModule interface
• Maintains alphabetical ordering of interface methods
dotnet/src/webdriver/BiDi/Emulation/IEmulationModule.cs

View more (1)

4. dotnet/test/common/BiDi/Emulation/EmulationTests.cs 🧪 Tests +26/-0

Add scrollbar override test cases

• Adds CanSetScrollbarTypeOverride test method with browser compatibility attributes
• Adds CanSetScrollbarTypeOverrideToDefault test for null parameter handling
• Tests marked as not supported for Chrome, Edge, and Firefox

dotnet/test/common/BiDi/Emulation/EmulationTests.cs

qodo-code-review · 2026-03-11T17:35:36Z

Code Review by Qodo

🐞 Bugs (2) 📘 Rule violations (2) 📎 Requirement gaps (0)

1. New IEmulationModule method 📘 Rule violation ✓ Correctness

Description

A new member was added to the public IEmulationModule interface, which is a breaking API/ABI
change for any downstream implementations of that interface. Existing consumers implementing
IEmulationModule will fail to compile (and may fail at runtime depending on binding/dispatch).

Code

dotnet/src/webdriver/BiDi/Emulation/IEmulationModule.cs[32]

+    Task<SetScrollbarTypeOverrideResult> SetScrollbarTypeOverrideAsync(ScrollbarType? scrollbarType, SetScrollbarTypeOverrideOptions? options = null, CancellationToken cancellationToken = default);

Evidence

PR Compliance ID 1 requires preserving public API/ABI compatibility. The PR adds
SetScrollbarTypeOverrideAsync(...) to the public IEmulationModule interface, which breaks
downstream implementers by introducing a new required member.

AGENTS.md
dotnet/src/webdriver/BiDi/Emulation/IEmulationModule.cs[22-33]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A new method was added to the public `IEmulationModule` interface, which is a breaking change for downstream implementers and violates API/ABI compatibility expectations.
## Issue Context
Downstream projects may implement `IEmulationModule`. Adding a new interface member forces them to update implementations, meaning they cannot upgrade by changing only the version number.
## Fix Focus Areas
- dotnet/src/webdriver/BiDi/Emulation/IEmulationModule.cs[22-33]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. Scrollbar tests always ignored 📘 Rule violation ⛯ Reliability ⭐ New

Description

The newly added tests for scrollbar override are ignored for Chrome, Edge, and Firefox, so they do
not provide effective coverage in CI. This undermines the requirement to include appropriate tests
for behavioral changes.

Code

dotnet/test/common/BiDi/Emulation/EmulationTests.cs[R134-158]

+    [Test]
+    [IgnoreBrowser(Selenium.Browser.Chrome, "Not supported yet?")]
+    [IgnoreBrowser(Selenium.Browser.Edge, "Not supported yet?")]
+    [IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
+    public void CanSetScrollbarTypeOverride()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(ScrollbarType.Overlay, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }
+
+    [Test]
+    [IgnoreBrowser(Selenium.Browser.Chrome, "Not supported yet?")]
+    [IgnoreBrowser(Selenium.Browser.Edge, "Not supported yet?")]
+    [IgnoreBrowser(Selenium.Browser.Firefox, "Not supported yet?")]
+    public void CanSetScrollbarTypeOverrideToDefault()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(null, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }

Evidence

PR Compliance ID 4 requires adding/updating tests when feasible. The added tests are explicitly
ignored on the major supported browsers, meaning the feature is effectively untested by these
additions.

AGENTS.md
dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-158]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The added tests for the new scrollbar override command are ignored for Chrome/Edge/Firefox, so they do not provide effective CI coverage.

## Issue Context
The compliance requirement expects tests for behavioral changes when feasible, preferring small/unit tests. If browser support is not available yet, a unit/serialization test can still validate the command payload and enum conversion.

## Fix Focus Areas
- dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-158]
- dotnet/src/webdriver/BiDi/Emulation/SetScrollbarTypeOverrideCommand.cs[25-44]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

3. Ungated new BiDi test 🐞 Bug ⛯ Reliability

Description

The new SetScrollbarTypeOverride tests run on all configured browsers without any feature-gating.
If a given browser/driver doesn’t implement emulation.setScrollbarTypeOverride yet, these tests
will fail and block CI even though the binding code is correct.

Code

dotnet/test/common/BiDi/Emulation/EmulationTests.cs[R134-152]

+    [Test]
+    public void CanSetScrollbarTypeOverride()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(ScrollbarType.Overlay, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }
+
+    [Test]
+    public void CanSetScrollbarTypeOverrideToDefault()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(null, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }

Evidence
The newly added tests are unconditional (no IgnoreBrowser) while other emulation override tests in
the same file explicitly use IgnoreBrowser when commands are not supported yet. The IgnoreBrowser
mechanism keys off EnvironmentManager.Instance.Browser, and the BiDi fixture creates a driver
based on that environment; therefore, without gating, the new tests will execute on whichever
browser is configured and fail if unsupported. Additionally, broker error responses are surfaced as
BiDiException, which could be used for feature-detection-based skipping if desired.
dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-152]
dotnet/test/common/BiDi/Emulation/EmulationTests.cs[86-110]
dotnet/test/common/CustomTestAttributes/IgnoreBrowserAttribute.cs[28-75]
dotnet/test/common/BiDi/BiDiFixture.cs[24-50]
dotnet/src/webdriver/BiDi/Broker.cs[224-230]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new scrollbar override tests run unconditionally. In environments where the underlying browser/driver doesn’t support `emulation.setScrollbarTypeOverride` yet, they can fail CI even though the client binding is correct.
### Issue Context
This test suite already uses `IgnoreBrowser` to avoid running unsupported BiDi commands on specific browsers.
### Fix Focus Areas
- dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-152]
- dotnet/test/common/BiDi/Emulation/EmulationTests.cs[86-110]
- dotnet/test/common/CustomTestAttributes/IgnoreBrowserAttribute.cs[28-75]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

4. Scrollbar tests are smoke-only 🐞 Bug ⛯ Reliability

Description

The new tests only assert that the command doesn’t throw and don’t validate that scrollbar behavior
actually changed or was reset. This is consistent with other tests in this file, but it limits the
tests’ ability to catch no-op implementations/regressions.

Code

dotnet/test/common/BiDi/Emulation/EmulationTests.cs[R134-152]

+    [Test]
+    public void CanSetScrollbarTypeOverride()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(ScrollbarType.Overlay, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }
+
+    [Test]
+    public void CanSetScrollbarTypeOverrideToDefault()
+    {
+        Assert.That(async () =>
+        {
+            await bidi.Emulation.SetScrollbarTypeOverrideAsync(null, new() { Contexts = [context] });
+        },
+        Throws.Nothing);
+    }

Evidence

Both added tests only wrap the async call and assert Throws.Nothing; there are no post-conditions
asserted (e.g., computed style/visual behavior checks).

dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-152]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Current tests only verify that the command call does not throw, which may not detect cases where the command is accepted but has no effect.
### Issue Context
This file uses smoke-style assertions for multiple emulation commands; consider adding at least one higher-signal assertion specifically for scrollbar behavior if practical.
### Fix Focus Areas
- dotnet/test/common/BiDi/Emulation/EmulationTests.cs[134-152]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

ⓘ The new review experience is currently in Beta. Learn more

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

[dotnet] [bidi] Add SetScrollbarTypeOverride command in Emulation module

9ab73e4

Copilot AI review requested due to automatic review settings March 3, 2026 18:20

nvborisenko marked this pull request as draft March 3, 2026 18:21

selenium-ci added the C-dotnet .NET Bindings label Mar 3, 2026

Copilot started reviewing on behalf of nvborisenko March 3, 2026 18:21 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

qodo-code-review bot reviewed Mar 3, 2026

View reviewed changes

dotnet/src/webdriver/BiDi/Emulation/IEmulationModule.cs Show resolved Hide resolved

nvborisenko added 2 commits March 11, 2026 20:31

Merge remote-tracking branch 'upstream/trunk' into bidi-set-scrollbar…

2189700

…-type

Ignore

d3bdffa

Copilot AI review requested due to automatic review settings March 11, 2026 17:35

nvborisenko marked this pull request as ready for review March 11, 2026 17:35

Copilot started reviewing on behalf of nvborisenko March 11, 2026 17:35 View session

Copilot AI reviewed Mar 11, 2026

View reviewed changes

nvborisenko merged commit 6ce07db into SeleniumHQ:trunk Mar 11, 2026
22 of 23 checks passed

nvborisenko deleted the bidi-set-scrollbar-type branch March 11, 2026 19:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[dotnet] [bidi] Add SetScrollbarTypeOverride command in Emulation module#17171

[dotnet] [bidi] Add SetScrollbarTypeOverride command in Emulation module#17171
nvborisenko merged 3 commits intoSeleniumHQ:trunkfrom
nvborisenko:bidi-set-scrollbar-type

nvborisenko commented Mar 3, 2026

Uh oh!

qodo-code-review bot commented Mar 3, 2026

Uh oh!

qodo-code-review bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

qodo-code-review bot commented Mar 11, 2026

Uh oh!

qodo-code-review bot commented Mar 11, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

nvborisenko commented Mar 3, 2026

💥 What does this PR do?

🔄 Types of changes

Uh oh!

qodo-code-review bot commented Mar 3, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

qodo-code-review bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

qodo-code-review bot commented Mar 11, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

qodo-code-review bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

qodo-code-review bot commented Mar 3, 2026 •

edited

Loading

qodo-code-review bot commented Mar 11, 2026 •

edited

Loading