[build] simplify release.yml: remove draft, build once during publish#16960
[build] simplify release.yml: remove draft, build once during publish#16960titusfortner merged 4 commits intotrunkfrom
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
||||||||||||||||||||||||
PR Code Suggestions ✨Latest suggestions up to 0c7a1ec
Previous suggestions✅ Suggestions up to commit 27f00a4
✅ Suggestions up to commit b9e2a03
✅ Suggestions up to commit 446402f
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Pull request overview
This PR simplifies the Selenium release workflow by consolidating the build and publish steps into a single operation, moving approval earlier in the process, and eliminating the draft GitHub release stage.
Changes:
- Moved approval step before building/publishing to gate the entire release process
- Consolidated build and publish into single per-language jobs that both build and release artifacts
- Removed draft GitHub release creation; now creates final release directly with artifacts
User description
🔗 Related Issues
Changes in #16955 allow us to simplify release process. Currently building twice once for upload and once for release.
💥 What does this PR do?
Old flow:
New flow:
🔧 Implementation Notes
Also removed unnecessary checkouts
Not differentiating between build and publish, but step names and logging info will tell us where problems are
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement
Description
Reorganize workflow to build and publish in single job
Move approval step before build to gate release process
Remove draft release creation, create final release directly
Eliminate unnecessary checkout and duplicate build steps
Download language-specific artifacts for final release
Diagram Walkthrough
File Walkthrough
release.yml
Consolidate build and publish, streamline approval workflow.github/workflows/release.yml
get-approvalbeforepublishtogate the release process
buildandpublishjobs into singlepublishjob thatbuilds and releases per language
create-releasedraft job;github-releasenow creates finalrelease directly
preparejob and unused permissionsgithub-releaseto download language-specific artifacts andremoved draft/update flags
"Generate Nightly Versions"
github-releasefinalization job that was updatingdraft to release