You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR improves the type hints on all of find_element/find_elements methods. It also fixes an incorrect type hint on the value arg in these methods for shadowroot.
This also updates the docstring in shadowroot/webelement that mentionRelativeBy since that is not supported in those methods.
🔄 Types of changes
Cleanup (formatting, renaming)
Bug fix (backwards compatible)
PR Type
Enhancement, Bug fix
Description
Fix value parameter type hint from str to str | None in shadowroot
Update return type hints to use modern generic syntax (list[WebElement])
Improve type safety across find_element/find_elements methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
💥 What does this PR do?
#15697
This PR improves the type hints on all of
find_element/find_elementsmethods. It also fixes an incorrect type hint on thevaluearg in these methods for shadowroot.This also updates the docstring in shadowroot/webelement that mention
RelativeBysince that is not supported in those methods.🔄 Types of changes
PR Type
Enhancement, Bug fix
Description
Fix
valueparameter type hint fromstrtostr | Nonein shadowrootUpdate return type hints to use modern generic syntax (
list[WebElement])Improve type safety across find_element/find_elements methods