Skip to content

Fixing NPE when "se:downloadsEnabled" not set#13583

Merged
diemol merged 1 commit intoSeleniumHQ:trunkfrom
Trigtrig:bugfix/hasdownloads_npe_fix
Feb 14, 2024
Merged

Fixing NPE when "se:downloadsEnabled" not set#13583
diemol merged 1 commit intoSeleniumHQ:trunkfrom
Trigtrig:bugfix/hasdownloads_npe_fix

Conversation

@Trigtrig
Copy link
Copy Markdown
Contributor

@Trigtrig Trigtrig commented Feb 14, 2024

Description

Fixes the NPE described in #13578. I'm using capabilities.is("se:downloadsEnabled") because this function already checks for possible null values and casts to boolean using Boolean.parseBoolean().

Motivation and Context

Fixes the NPE described in #13578.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6b2096) 58.48% compared to head (5180adc) 58.48%.

❗ Current head 5180adc differs from pull request most recent head cb18a11. Consider uploading reports for the commit cb18a11 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk   #13583   +/-   ##
=======================================
  Coverage   58.48%   58.48%           
=======================================
  Files          86       86           
  Lines        5270     5270           
  Branches      220      220           
=======================================
  Hits         3082     3082           
  Misses       1968     1968           
  Partials      220      220

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

diemol
diemol approved these changes Feb 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Trigtrig!

@diemol diemol linked an issue Feb 14, 2024 that may be closed by this pull request
[🐛 Bug]: NPE in HasDownloads.requireDownloadsEnabled() when using local browser #13578
Closed
@diemol diemol merged commit 3338c08 into SeleniumHQ:trunk Feb 14, 2024
@Trigtrig Trigtrig mentioned this pull request Feb 28, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: NPE in HasDownloads.requireDownloadsEnabled() when using local browser

4 participants

@Trigtrig @CLAassistant @codecov-commenter @diemol