[py] deprecate FirefoxBinary class#13476
Merged
titusfortner merged 2 commits intotrunkfrom Jan 21, 2024
Merged
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13476 +/- ##
==========================================
+ Coverage 58.37% 58.46% +0.08%
==========================================
Files 86 86
Lines 5266 5270 +4
Branches 222 220 -2
==========================================
+ Hits 3074 3081 +7
+ Misses 1970 1969 -1
+ Partials 222 220 -2 ☔ View full report in Codecov by Sentry. |
diemol
approved these changes
Jan 21, 2024
pass in location of firefox with binary_location property in Options class
ca50850 to
3d241f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deprecates the class and the properties on Firefox Options that is the only place the class is used
Motivation and Context
The class was created to manage starting and stopping the browser, which has not been necessary since the move to geckodriver. It is currently only used for storing the location of the browser, which is already duplicated behavior of binary_location() method.
Note: making use of the new deprecated annotation which is nice.