[grid] add value key to downloadFile response per w3c convention#13025
Merged
[grid] add value key to downloadFile response per w3c convention#13025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13025 +/- ##
=======================================
Coverage 56.49% 56.49%
=======================================
Files 86 86
Lines 5255 5255
Branches 187 187
=======================================
Hits 2969 2969
Misses 2099 2099
Partials 187 187 ☔ View full report in Codecov by Sentry. |
diemol
approved these changes
Oct 23, 2023
Member
diemol
left a comment
There was a problem hiding this comment.
Good catch, thank you, @titusfortner!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a value key to the delete downloadFile response
Motivation and Context
Per the W3C Processing Model
Ruby expects to see a value key from all responses, even if the data value is
null