Skip to content

[grid] fix bug in downloading files by ensuring browser vendor option…#13024

Merged
diemol merged 5 commits intotrunkfrom
missing_optionsKey
Oct 24, 2023
Merged

[grid] fix bug in downloading files by ensuring browser vendor option…#13024
diemol merged 5 commits intotrunkfrom
missing_optionsKey

Conversation

@titusfortner
Copy link
Member

@titusfortner titusfortner commented Oct 22, 2023

Description

If browser vendor options missing, merge in mutable capabilities with the capabilities set.
I think this is better than casting the capabilities to MutableCapabilities to add it?

Motivation and Context

Not all bindings create an empty browser vendor options map by default

@titusfortner
[java] fix bug in downloading files by ensuring browser vendor option…
82b37c5 
…s in capabilities

Not all bindings create an empty browser vendor options map by default
@titusfortner titusfortner added the B-grid Everything grid and server related label Oct 22, 2023
@titusfortner titusfortner mentioned this pull request Oct 22, 2023
Merged
@titusfortner titusfortner changed the title [java] fix bug in downloading files by ensuring browser vendor option… [grid] fix bug in downloading files by ensuring browser vendor option… Oct 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d810ac9) 56.49% compared to head (2a2369a) 56.49%.
Report is 10 commits behind head on trunk.

❗ Current head 2a2369a differs from pull request most recent head 3073c31. Consider uploading reports for the commit 3073c31 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk   #13024   +/-   ##
=======================================
  Coverage   56.49%   56.49%           
=======================================
  Files          86       86           
  Lines        5255     5255           
  Branches      187      187           
=======================================
  Hits         2969     2969           
  Misses       2099     2099           
  Partials      187      187

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

diemol
diemol reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the bug? In the absence of browser options key or the casting? In theory ofNullable should be handling it.

@titusfortner
Copy link
Member Author

titusfortner commented Oct 23, 2023

If there isn't a moz:firefoxOptions key, then we're just mutating a new hash that isn't attached to anything. Python downloading doesn't work unless another geckodriver option happens to be set.

diemol
diemol approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the explanation

@titusfortner
Copy link
Member Author

titusfortner commented Oct 23, 2023

What, the description made complete sense in my mind... 😂

I'll fix the formatting.

@diemol diemol merged commit d8d4068 into trunk Oct 24, 2023
@diemol diemol deleted the missing_optionsKey branch October 24, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

@krmahadevan krmahadevan Awaiting requested review from krmahadevan

Assignees

No one assigned

Labels

B-grid Everything grid and server related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@titusfortner @codecov-commenter @diemol