[java] Removes deprecated events classes #11819#12578
[java] Removes deprecated events classes #11819#12578dev-velo wants to merge 5 commits intoSeleniumHQ:trunkfrom
Conversation
|
Because this is both a major change and is something there isn't a lot of conversation around, we would like to have documentation for the new code and some kind of blog post talking about how to upgrade, etc. That's why we've kept this code around long after it should have been removed. Would you be interested in helping us with that? |
|
@RevealOscar do you think you can help us document |
|
@titusfortner @diemol |
| */ | ||
| default void afterPerform(WebDriver driver, Collection<Sequence> actions) {} | ||
|
|
||
| default void beforeResetInputState(WebDriver driver) {} |
There was a problem hiding this comment.
Just curious, why were these removed from the interface?
| "afterGet", | ||
| "afterAnyWebDriverCall get", | ||
| "afterAnyCall get")); | ||
| "beforeAnyWebDriverCall getCurrentUrl", |
There was a problem hiding this comment.
I appreciate adding exhaustive tests. But it might be a good idea to split the PRs out. For example, removal could be one PR and one PR could be adding tests. It will help with cleaner commits.
|
@RevealOscar Thank you for the blog post. It's great. Would you help us add it as a blog post/tutorial as part of the Selenium website? https://github.com/SeleniumHQ/seleniumhq.github.io. |
|
@RevealOscar Can you please help resolve the conflicts? |
|
@pujagani yea I can resolve the conflicts and split the pr into 2. in the process of getting a new machine so havent been able to look at the pr |
|
Thank you @RevealOscar! Let us know if we can help you in anyway. |
|
@pujagani apologies for the delay but I finally was able to get a new laptop and picked the work back up. feel free to close this PR as I split this work into separate PR's. |
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Remove deprecated event classes as described in #11819
Motivation and Context
Classes were deprecated in 4.0
Types of changes
Checklist
removes deprecated code