[JS] [atoms] update fragment wrapper to apply window object to fragments#12557
Merged
AutomatedTester merged 2 commits intotrunkfrom Aug 16, 2023
Merged
[JS] [atoms] update fragment wrapper to apply window object to fragments#12557AutomatedTester merged 2 commits intotrunkfrom
AutomatedTester merged 2 commits intotrunkfrom
Conversation
Member
|
The CI failures seem to be fall out from test updates I did the other day. |
AutomatedTester
approved these changes
Aug 16, 2023
2 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #12549
went ahead and made a PR in case this works. All the atoms built with this change have passed Appium's mobile safari e2e test suite. It doesn't appear to break too many things. Let's see what Selenium CI says.