[rb] move Driver Finder logic out of Selenium Manager#12429
Closed
titusfortner wants to merge 2 commits intotrunkfrom
Closed
[rb] move Driver Finder logic out of Selenium Manager#12429titusfortner wants to merge 2 commits intotrunkfrom
titusfortner wants to merge 2 commits intotrunkfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
(Draft)
Description
This makes the
SeleniumManagerclass a light wrapper of the binary. It only locates and executes. All processing of what goes to and what comes out of the Manager is done in theDriverFinderclass.Motivation and Context
The idea is we can release it as a separate gem and allow users of older Selenium versions to have access to the latest. I'm looking for an alternative to updating webdrivers based on conversation here titusfortner/webdrivers#247
With a
selenium-manager.gem,webdrivers.gemcan become a super small wrapper that allows backwards compatibility.