Skip to content

[rb] have Selenium Manager binary locate drivers on PATH#12345

Merged
titusfortner merged 1 commit intotrunkfrom
rb_path
Jul 13, 2023
Merged

[rb] have Selenium Manager binary locate drivers on PATH#12345
titusfortner merged 1 commit intotrunkfrom
rb_path

Conversation

@titusfortner
Copy link
Copy Markdown
Member

@titusfortner titusfortner commented Jul 12, 2023

Description

  • Remove the use of Platform#find_binary in DriverFinder
  • Remove #find_binary from Platform
  • Fixed unit tests

Motivation and Context

Considerations

  • It is possible for this to be a breaking change since the find_binary logic may differ slightly from the binary, but it is unlikely and warnings will be thrown in the console.
  • Are there any of these methods in this API private class that I'm deleting that we want to keep?

@titusfortner titusfortner added the C-rb Ruby Bindings label Jul 12, 2023
@titusfortner titusfortner requested a review from p0deje July 12, 2023 03:35
@titusfortner titusfortner mentioned this pull request Jul 12, 2023
Closed
p0deje
p0deje approved these changes Jul 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@p0deje p0deje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@titusfortner titusfortner merged commit 054467a into trunk Jul 13, 2023
@titusfortner titusfortner deleted the rb_path branch July 13, 2023 13:32
@gaffneyc gaffneyc mentioned this pull request Aug 7, 2023
Closed
@zarembas zarembas mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@p0deje p0deje p0deje approved these changes

Assignees

No one assigned

Labels

C-rb Ruby Bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@titusfortner @p0deje