Skip to content

[rust] Update PATH processing mechanism by Selenium Manager#12291

Merged
bonigarcia merged 2 commits intotrunkfrom
se_mgr_path
Jul 3, 2023
Merged

[rust] Update PATH processing mechanism by Selenium Manager#12291
bonigarcia merged 2 commits intotrunkfrom
se_mgr_path

Conversation

@bonigarcia
Copy link
Copy Markdown
Member

@bonigarcia bonigarcia commented Jun 29, 2023

Description

This PR modifies the behaviour of Selenium Manager with respect to the way in which the drivers in PATH are processed.

Motivation and Context

This PR fixes #12177. The output to the proposed scenarios is as follows:

Old driver on PATH with Internet

C:\Users\boni\Documents\dev\selenium\rust>cargo run -- --browser chrome --debug --clear-cache
   Compiling selenium-manager v1.0.0-M3 (C:\Users\boni\Documents\dev\selenium\rust)
    Finished dev [unoptimized + debuginfo] target(s) in 1.78s
     Running `target\debug\selenium-manager.exe --browser chrome --debug --clear-cache`
DEBUG   Clearing cache at: C:\Users\boni\.cache\selenium
DEBUG   Running command: "chromedriver --version"
DEBUG   Output: "ChromeDriver 107.0.5304.62 (1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942})"
DEBUG   Running command: "where chromedriver"
DEBUG   Output: "C:\\Users\\boni\\Documents\\bat\\chromedriver.exe"
DEBUG   Found chromedriver 107.0.5304.62 in PATH: C:\Users\boni\Documents\bat\chromedriver.exe
DEBUG   Using shell command to find out chrome version
DEBUG   Running command: "set PFILES=%PROGRAMFILES: (x86)=%&& wmic datafile where name='!PFILES:\\=\\\\!\\\\Google\\\\Chrome\\\\Application\\\\chrome.exe' get Version /value"
DEBUG   Output: "\r\r\n\r\r\nVersion=114.0.5735.199\r\r\n\r\r\n\r\r\n\r"
DEBUG   Detected browser: chrome 114.0.5735.199
DEBUG   Reading chromedriver version from https://chromedriver.storage.googleapis.com/LATEST_RELEASE_114
DEBUG   Required driver: chromedriver 114.0.5735.90
WARN    Incompatible release of chromedriver (version 107.0.5304.62) detected in PATH: C:\Users\boni\Documents\bat\chromedriver.exe
INFO    C:\Users\boni\Documents\bat\chromedriver.exe

Current driver on PATH with Internet

C:\Users\boni\Documents\dev\selenium\rust>cargo run -- --browser chrome --debug --clear-cache
    Finished dev [unoptimized + debuginfo] target(s) in 0.23s
     Running `target\debug\selenium-manager.exe --browser chrome --debug --clear-cache`
DEBUG   Clearing cache at: C:\Users\boni\.cache\selenium
DEBUG   Running command: "chromedriver --version"
DEBUG   Output: "ChromeDriver 114.0.5735.90 (386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052})"
DEBUG   Running command: "where chromedriver"
DEBUG   Output: "C:\\Users\\boni\\Documents\\bat\\chromedriver.exe"
DEBUG   Found chromedriver 114.0.5735.90 in PATH: C:\Users\boni\Documents\bat\chromedriver.exe
DEBUG   Using shell command to find out chrome version
DEBUG   Running command: "set PFILES=%PROGRAMFILES: (x86)=%&& wmic datafile where name='!PFILES:\\=\\\\!\\\\Google\\\\Chrome\\\\Application\\\\chrome.exe' get Version /value"
DEBUG   Output: "\r\r\n\r\r\nVersion=114.0.5735.199\r\r\n\r\r\n\r\r\n\r"
DEBUG   Detected browser: chrome 114.0.5735.199
DEBUG   Reading chromedriver version from https://chromedriver.storage.googleapis.com/LATEST_RELEASE_114
DEBUG   Required driver: chromedriver 114.0.5735.90
INFO    C:\Users\boni\Documents\bat\chromedriver.exe

Old driver on PATH without Internet

C:\Users\boni\Documents\dev\selenium\rust>cargo run -- --browser chrome --debug --clear-cache
    Finished dev [unoptimized + debuginfo] target(s) in 0.25s
     Running `target\debug\selenium-manager.exe --browser chrome --debug --clear-cache`
DEBUG   Clearing cache at: C:\Users\boni\.cache\selenium
DEBUG   Running command: "chromedriver --version"
DEBUG   Output: "ChromeDriver 107.0.5304.62 (1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942})"
DEBUG   Running command: "where chromedriver"
DEBUG   Output: "C:\\Users\\boni\\Documents\\bat\\chromedriver.exe"
DEBUG   Found chromedriver 107.0.5304.62 in PATH: C:\Users\boni\Documents\bat\chromedriver.exe
DEBUG   Using shell command to find out chrome version
DEBUG   Running command: "set PFILES=%PROGRAMFILES: (x86)=%&& wmic datafile where name='!PFILES:\\=\\\\!\\\\Google\\\\Chrome\\\\Application\\\\chrome.exe' get Version /value"
DEBUG   Output: "\r\r\n\r\r\nVersion=114.0.5735.199\r\r\n\r\r\n\r\r\n\r"
DEBUG   Detected browser: chrome 114.0.5735.199
DEBUG   Reading chromedriver version from https://chromedriver.storage.googleapis.com/LATEST_RELEASE_114
WARN    Exception trying to discover chromedriver version: error sending request for url (https://chromedriver.storage.googleapis.com/LATEST_RELEASE_114): error trying to connect: dns error: No such host is known. (os error 11001)
INFO    C:\Users\boni\Documents\bat\chromedriver.exe

Current driver on PATH without Internet

C:\Users\boni\Documents\dev\selenium\rust>cargo run -- --browser chrome --debug --clear-cache
    Finished dev [unoptimized + debuginfo] target(s) in 0.23s
     Running `target\debug\selenium-manager.exe --browser chrome --debug --clear-cache`
DEBUG   Clearing cache at: C:\Users\boni\.cache\selenium
DEBUG   Running command: "chromedriver --version"
DEBUG   Output: "ChromeDriver 107.0.5304.62 (1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942})"
DEBUG   Running command: "where chromedriver"
DEBUG   Output: "C:\\Users\\boni\\Documents\\bat\\chromedriver.exe"
DEBUG   Found chromedriver 107.0.5304.62 in PATH: C:\Users\boni\Documents\bat\chromedriver.exe
DEBUG   Using shell command to find out chrome version
DEBUG   Running command: "set PFILES=%PROGRAMFILES: (x86)=%&& wmic datafile where name='!PFILES:\\=\\\\!\\\\Google\\\\Chrome\\\\Application\\\\chrome.exe' get Version /value"
DEBUG   Output: "\r\r\n\r\r\nVersion=114.0.5735.199\r\r\n\r\r\n\r\r\n\r"
DEBUG   Detected browser: chrome 114.0.5735.199
DEBUG   Reading chromedriver version from https://chromedriver.storage.googleapis.com/LATEST_RELEASE_114
WARN    Exception trying to discover chromedriver version: error sending request for url (https://chromedriver.storage.googleapis.com/LATEST_RELEASE_114): error trying to connect: dns error: No such host is known. (os error 11001)
INFO    C:\Users\boni\Documents\bat\chromedriver.exe

Current driver on PATH with Internet but invalid proxy

C:\Users\boni\Documents\dev\selenium\rust>cargo run -- --browser chrome --debug --clear-cache --proxy http://localhost:9999
    Finished dev [unoptimized + debuginfo] target(s) in 0.23s
     Running `target\debug\selenium-manager.exe --browser chrome --debug --clear-cache --proxy http://localhost:9999`
DEBUG   Clearing cache at: C:\Users\boni\.cache\selenium
DEBUG   Using proxy: http://localhost:9999
DEBUG   Running command: "chromedriver --version"
DEBUG   Output: "ChromeDriver 114.0.5735.90 (386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052})"
DEBUG   Running command: "where chromedriver"
DEBUG   Output: "C:\\Users\\boni\\Documents\\bat\\chromedriver.exe"
DEBUG   Found chromedriver 114.0.5735.90 in PATH: C:\Users\boni\Documents\bat\chromedriver.exe
DEBUG   Using shell command to find out chrome version
DEBUG   Running command: "set PFILES=%PROGRAMFILES: (x86)=%&& wmic datafile where name='!PFILES:\\=\\\\!\\\\Google\\\\Chrome\\\\Application\\\\chrome.exe' get Version /value"
DEBUG   Output: "\r\r\n\r\r\nVersion=114.0.5735.199\r\r\n\r\r\n\r\r\n\r"
DEBUG   Detected browser: chrome 114.0.5735.199
DEBUG   Reading chromedriver version from https://chromedriver.storage.googleapis.com/LATEST_RELEASE_114
WARN    Exception trying to discover chromedriver version: error sending request for url (https://chromedriver.storage.googleapis.com/LATEST_RELEASE_114): error trying to connect: tcp connect error: No connection could be made because the target machine actively refused it. (os error 10061)
INFO    C:\Users\boni\Documents\bat\chromedriver.exe

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia added the C-rust Rust code is mostly Selenium Manager label Jun 29, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 29, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (2fd7dd7) 56.92% compared to head (bff7843) 56.92%.

❗ Current head bff7843 differs from pull request most recent head 3a0db79. Consider uploading reports for the commit 3a0db79 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@           Coverage Diff           @@
##            trunk   #12291   +/-   ##
=======================================
  Coverage   56.92%   56.92%           
=======================================
  Files          86       86           
  Lines        5423     5423           
  Branches      193      193           
=======================================
  Hits         3087     3087           
  Misses       2143     2143           
  Partials      193      193

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

diemol
diemol reviewed Jun 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARN Incompatible release of chromedriver (version 107.0.5304.62) detected in PATH: C:\Users\boni\Documents\bat\chromedriver.exe

I believe ChromeDriver 114 works with Chrome 115 (and 116?), right? Should we change this message to something like:

WARN Release of chromedriver (version 107.0.5304.62) detected in PATH: C:\Users\boni\Documents\bat\chromedriver.exe does not match chrome 114.0.5735.199, session might be unstable or not start

Maybe avoiding the "incompatible" and noting the consequence of the incompatibility is more helpful for users.

Aside of that, it looks good to me, thanks @bonigarcia!

@titusfortner
Copy link
Copy Markdown
Member

titusfortner commented Jun 30, 2023

I like mentioning both versions. I think "incompatible" is fine; they are almost always going to see this warning just before a big error message about the versions being mismatched. Maybe we should explicitly suggest the recommended solution in the warning?

WARN The chromedriver version (107.0.5304.62) detected in PATH at C:\Users\boni\Documents\bat\chromedriver.exe is not compatible with the detected Chrome version (114.0.5735.199); it is recommended to delete the driver and retry

@bonigarcia
Copy link
Copy Markdown
Member Author

bonigarcia commented Jun 30, 2023

Indeed, "incompatible" is not always accurate since drivers are typically compatible with several browser versions. So yes, both of your messages are better since they provide more info. I have just added a new commit changing it.

@bonigarcia bonigarcia merged commit 50f9252 into trunk Jul 3, 2023
@bonigarcia bonigarcia deleted the se_mgr_path branch July 3, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diemol diemol diemol approved these changes

Assignees

No one assigned

Labels

C-rust Rust code is mostly Selenium Manager

Projects

Selenium Manager
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Selenium Manager should not remediate issues with Drivers on PATH

4 participants

@bonigarcia @codecov-commenter @titusfortner @diemol