-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
Closed
Closed
Copy link
Labels
A-needs-triagingA Selenium member will evaluate this soon!A Selenium member will evaluate this soon!B-devtoolsIncludes everything BiDi or Chrome DevTools relatedIncludes everything BiDi or Chrome DevTools relatedC-dotnet.NET Bindings.NET BindingsI-enhancementSomething could be betterSomething could be better
Description
Description
Now:
await context.NavigateAsync("https://google.com/", new() { Wait = ReadinessState.Complete, Timeout = TimeSpan.FromSeconds(50) });
// 30 secs by defaultProposed:
await context.NavigateAsync("https://google.com/", new() { Wait = ReadinessState.Complete, Timeout = TimeSpan.FromSeconds(50) }, CancellationToken.None); // any optional tokenAPI:
ExecuteSomeCommandAsync(string param1, ..., ExecuteSomeCommandOptions? = null, CancellationToken? cancellationToken = default)Implementation notes
It should honor both provided, Timeout + CancellationToken via linked cancellation token source.
Have you considered any alternatives or workarounds?
Timeout is a winner in 99% cases. But to be modern library just follow best practices.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-needs-triagingA Selenium member will evaluate this soon!A Selenium member will evaluate this soon!B-devtoolsIncludes everything BiDi or Chrome DevTools relatedIncludes everything BiDi or Chrome DevTools relatedC-dotnet.NET Bindings.NET BindingsI-enhancementSomething could be betterSomething could be better