Skip to content

Docker: Add package fonts-thai-tlwg-ttf for Thai language #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
VietND96 merged 1 commit into from
Dec 22, 2025
Merged

Docker: Add package fonts-thai-tlwg-ttf for Thai language #3052

VietND96 merged 1 commit into from
Dec 22, 2025

Conversation

@VietND96
Copy link
Member

@VietND96 VietND96 commented Dec 22, 2025 •
edited by qodo-code-review bot
Loading

User description

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fixes #3043

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement

Description

  • Add Thai language font package to Docker image

  • Installs fonts-thai-tlwg-ttf for Thai text rendering support

Diagram Walkthrough

flowchart LR
  A["NodeBase Dockerfile"] -- "adds Thai font package" --> B["fonts-thai-tlwg-ttf dependency"]
  B -- "enables" --> C["Thai language support"]
Loading

File Walkthrough
Relevant files
Dependencies
Dockerfile
Add Thai font package to dependencies                                       

NodeBase/Dockerfile

  • Added fonts-thai-tlwg-ttf package to apt-get install command
  • Placed in locale and encoding settings section alongside other font
    packages
  • Enables Thai language text rendering in Docker container
 +1/-0     

@VietND96
Docker: Add package fonts-thai-tlwg-ttf for Thai language
acacda1 
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Dec 22, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🟡
🎫 #3043
🟢 Fix Thai text rendering being incorrect when using selenium/node-chrome:142.0 in Selenium
Grid (i.e., ensure Thai glyphs display correctly in Chrome inside the container).
⚪ Confirm in a running container based on the updated image that Thai text on the reported
page renders correctly (visual/UI verification and/or screenshot comparison), including in
VNC/noVNC sessions.
Codebase Duplication Compliance
⚪
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Dec 22, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
Possible issue
Refresh font cache after installing fonts

Add the fontconfig package and run fc-cache -f -v after the installation to
refresh the font cache and make the new fonts available.

NodeBase/Dockerfile [94]

 fonts-thai-tlwg-ttf \
+fontconfig \
  • Apply / Chat
Suggestion importance[1-10]: 7

__

Why: The suggestion correctly points out that the font cache needs to be rebuilt using fc-cache after installing new fonts, which is a crucial step to make them available to applications in the container.

Medium
  • More

@VietND96 VietND96 merged commit 4c20853 into trunk Dec 22, 2025
81 of 85 checks passed
@VietND96 VietND96 deleted the fix-Thai-font branch December 22, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Review effort 2/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: When performing automation using the selenium/node-chrome:142.0 image, the displayed Thai text is incorrect

2 participants

@VietND96