Skip to content

Add support for tls callback #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mbilski merged 1 commit into from
Jan 25, 2024
Merged

Add support for tls callback #99

mbilski merged 1 commit into from
Jan 25, 2024

Conversation

@mbilski
Copy link
Contributor

@mbilski mbilski commented Jan 25, 2024 •
edited
Loading

This adds support for using TLS in callback redirect URL as requested in #98

Example:

go run . https://oauth2c.us.authz.cloudentity.io/oauth2c/demo \
  --client-id cauktionbud6q8ftlqq0 \
  --client-secret HCwQ5uuUWBRHd04ivjX5Kl0Rz8zxMOekeLtqzki0GPc \
  --response-types code \
  --response-mode query \
  --grant-type authorization_code \
  --auth-method client_secret_basic \
  --redirect-url https://localhost:9876/callback \
  --callback-tls-cert https://raw.githubusercontent.com/cloudentity/oauth2c/master/data/cert.pem \
  --callback-tls-key https://raw.githubusercontent.com/cloudentity/oauth2c/master/data/key.pem

OAuth2c automatically detects the need for TLS if the redirect-url contains https schema. In this case, it is required to provide callback-tls-cert and callback-tls-key

@mbilski mbilski requested a review from ikawalec January 25, 2024 10:07
@mbilski mbilski merged commit 1777dd0 into master Jan 25, 2024
@mbilski mbilski deleted the feature/callback-tls branch January 25, 2024 11:03
@mbilski mbilski mentioned this pull request Jan 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikawalec ikawalec ikawalec approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mbilski @ikawalec