Conversation
The low surrogate detection range 0xDCEE..=0xDFFF is incorrect and should be 0xDC00..=0xDFFF. The current range misses surrogates 0xDC00 through 0xDCED, causing incorrect UTF-8 byte count calculation for supplementary Unicode characters (emoji, CJK Extension B, etc.) written to the Windows console. This results in the Write trait reporting fewer bytes written than actually consumed, potentially causing callers to re-send data or corrupt output. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Verifies the full low surrogate range U+DC00..=U+DFFF is recognized for correct UTF-16 to UTF-8 byte counting in Windows console output. Code units 0xDC00..0xDCED were previously misclassified. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #377
The low surrogate detection range
0xDCEE..=0xDFFFis incorrect and should be0xDC00..=0xDFFF. This misses surrogates 0xDC00 through 0xDCED, causing incorrect UTF-8 byte count calculation for supplementary Unicode characters written to the Windows console.