Skip to content

fix: change unit for memory from MB to MiB#2313

Merged
nicomiguelino merged 1 commit intoScreenly:masterfrom
nicomiguelino:change-label-from-mb-to-mib
Jun 2, 2025
Merged

fix: change unit for memory from MB to MiB#2313
nicomiguelino merged 1 commit intoScreenly:masterfrom
nicomiguelino:change-label-from-mb-to-mib

Conversation

@nicomiguelino
Copy link
Contributor

@nicomiguelino nicomiguelino commented Jun 2, 2025

Issues Fixed

  • System memory values are obtained from the back-end in bytes.
  • Those values were bit shifted by 20 digits to the right.
  • Since bit shift operations were done, it's more appropriate to use MiB instead of MB.

Description

  • Change the unit for system memory from megabytes (MB) to mebibytes (MiB). More details can be found here.

Checklist

  • I have performed a self-review of my own code.
  • New and existing unit tests pass locally and on CI with my changes.
  • I have done an end-to-end test for Raspberry Pi devices.
  • I have tested my changes for x86 devices.
  • I added a documentation for the changes I have made (when necessary).

Screenshots

Before

image

After

image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2025

@nicomiguelino nicomiguelino marked this pull request as ready for review June 2, 2025 17:59
@nicomiguelino nicomiguelino requested a review from a team as a code owner June 2, 2025 17:59
@nicomiguelino nicomiguelino merged commit 1c7fa2c into Screenly:master Jun 2, 2025
6 checks passed
@nicomiguelino nicomiguelino deleted the change-label-from-mb-to-mib branch June 2, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant