Skip to content

fix: reload settings when GET /api/v2/device_settings gets called#2297

Merged
nicomiguelino merged 1 commit intoScreenly:masterfrom
nicomiguelino:fix-get-device-settings-endpoint
May 23, 2025
Merged

fix: reload settings when GET /api/v2/device_settings gets called#2297
nicomiguelino merged 1 commit intoScreenly:masterfrom
nicomiguelino:fix-get-device-settings-endpoint

Conversation

@nicomiguelino
Copy link
Contributor

Issues Fixed

When a backup file gets uploaded and recovered, the changes in settings won't take place until you restart the web server or until Settings page gets accessed via browser.

Description

  • Updated GET /api/v2/device_settings so that settings.load() gets called.

Checklist

  • I have performed a self-review of my own code.
  • New and existing unit tests pass locally and on CI with my changes.
  • I have done an end-to-end test for Raspberry Pi devices.
  • I have tested my changes for x86 devices.
  • I added a documentation for the changes I have made (when necessary).

@sonarqubecloud
Copy link

@nicomiguelino nicomiguelino marked this pull request as ready for review May 23, 2025 22:43
@nicomiguelino nicomiguelino requested a review from a team as a code owner May 23, 2025 22:43
@nicomiguelino nicomiguelino merged commit 99700d7 into Screenly:master May 23, 2025
8 checks passed
@nicomiguelino nicomiguelino deleted the fix-get-device-settings-endpoint branch May 23, 2025 22:43
@nicomiguelino nicomiguelino added the api Changes to REST API label May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Changes to REST API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant