Skip to content

api: make response fields for the integrations endpoint nullable#2294

Merged
nicomiguelino merged 2 commits intoScreenly:masterfrom
nicomiguelino:fix-integrations-endpoint-schema
May 23, 2025
Merged

api: make response fields for the integrations endpoint nullable#2294
nicomiguelino merged 2 commits intoScreenly:masterfrom
nicomiguelino:fix-integrations-endpoint-schema

Conversation

@nicomiguelino
Copy link
Contributor

@nicomiguelino nicomiguelino commented May 22, 2025

Issues Fixed

  • Some Balena-related environment variables might not be present, which could result to getenv calls returning null.

Description

  • Made the all response fields for the /api/v2/integrations endpoint nullable to prevent schema-related errors

Checklist

  • I have performed a self-review of my own code.
  • New and existing unit tests pass locally and on CI with my changes.
  • I have done an end-to-end test for Raspberry Pi devices.
  • I have tested my changes for x86 devices.
  • I added a documentation for the changes I have made (when necessary).

@nicomiguelino nicomiguelino added the api Changes to REST API label May 22, 2025
@sonarqubecloud
Copy link

@nicomiguelino nicomiguelino marked this pull request as ready for review May 23, 2025 01:22
@nicomiguelino nicomiguelino requested a review from a team as a code owner May 23, 2025 01:22
@nicomiguelino nicomiguelino merged commit d84f018 into Screenly:master May 23, 2025
8 checks passed
@nicomiguelino nicomiguelino deleted the fix-integrations-endpoint-schema branch May 23, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Changes to REST API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant