Skip to content

api: update GET /api/v2/device_settings response#2293

Merged
nicomiguelino merged 1 commit intoScreenly:masterfrom
nicomiguelino:update-get-settings-endpoint
May 21, 2025
Merged

api: update GET /api/v2/device_settings response#2293
nicomiguelino merged 1 commit intoScreenly:masterfrom
nicomiguelino:update-get-settings-endpoint

Conversation

@nicomiguelino
Copy link
Contributor

@nicomiguelino nicomiguelino commented May 21, 2025

Description

  • Updated GET /api/v2/device_settings so that username will be included in the response

Checklist

  • I have performed a self-review of my own code.
  • New and existing unit tests pass locally and on CI with my changes.
  • I have done an end-to-end test for Raspberry Pi devices.
  • I have tested my changes for x86 devices.
  • I added a documentation for the changes I have made (when necessary).

@nicomiguelino nicomiguelino added the api Changes to REST API label May 21, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 21, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nicomiguelino nicomiguelino marked this pull request as ready for review May 21, 2025 20:36
@nicomiguelino nicomiguelino requested a review from a team as a code owner May 21, 2025 20:36
@nicomiguelino nicomiguelino merged commit a4e19cf into Screenly:master May 21, 2025
8 checks passed
@nicomiguelino nicomiguelino deleted the update-get-settings-endpoint branch May 21, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api Changes to REST API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nicomiguelino