Skip to content

feat: add a new V2 endpoint for showing system info#2266

Merged
nicomiguelino merged 1 commit intoScreenly:masterfrom
nicomiguelino:create-v2-info-endpoint
Apr 16, 2025
Merged

feat: add a new V2 endpoint for showing system info#2266
nicomiguelino merged 1 commit intoScreenly:masterfrom
nicomiguelino:create-v2-info-endpoint

Conversation

@nicomiguelino
Copy link
Contributor

Description

  • Adds a new v2 endpoint for showing the system info

Checklist

  • I have performed a self-review of my own code.
  • New and existing unit tests pass locally and on CI with my changes.
  • I have done an end-to-end test for Raspberry Pi devices.
  • I have tested my changes for x86 devices.
  • I added a documentation for the changes I have made (when necessary).

@nicomiguelino nicomiguelino requested a review from Copilot April 16, 2025 17:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

api/views/v1.py:174

  • [nitpick] Consider renaming this class to InfoViewV1 for clarity and consistency with the v2 endpoint naming, which could help avoid ambiguity when referencing version-specific endpoints.
class InfoView(InfoViewMixin):

@sonarqubecloud
Copy link

@nicomiguelino nicomiguelino marked this pull request as ready for review April 16, 2025 17:31
@nicomiguelino nicomiguelino requested a review from a team as a code owner April 16, 2025 17:31
@nicomiguelino nicomiguelino merged commit e042236 into Screenly:master Apr 16, 2025
8 checks passed
@nicomiguelino nicomiguelino deleted the create-v2-info-endpoint branch April 16, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants