Skip to content

WIP Better collision#57

Closed
centiweeger22 wants to merge 14 commits intoScratchEverywhere:mainfrom
centiweeger22:main
Closed

WIP Better collision#57
centiweeger22 wants to merge 14 commits intoScratchEverywhere:mainfrom
centiweeger22:main

Conversation

@centiweeger22
Copy link

collisionSmall

The collision could definitely be better, so this uses simple collision shapes instead of just boxes. It runs pretty well in a basic project unless there's more than around 400 collision points.

It still needs:

  • Collision shape detection (right now it's all circles)
  • Compatibility with SDL version (code relies on 3ds citro version)

@NateXS
Copy link
Member

NateXS commented Jul 19, 2025

Woah cool! Looks good so far, good luck on finishing this!

@centiweeger22
Copy link
Author

{19CDA4AE-EC60-4E35-813C-52764D064467} it's almost working on citro2d!!!! stupid citro2d swizzle magic got me all confused but reading from the rgba instead of the C2D_Image data worked

@centiweeger22
Copy link
Author

ughhh now i have to align and scale the hitboxes for real now 😩

@centiweeger22
Copy link
Author

centiweeger22 commented Aug 7, 2025

i took a break and still can't figure out how to align and scale the hitboxes for real 🙁
collisionjank
my branch is probably super behind, too.

@gradylink
Copy link
Member

gradylink commented Aug 7, 2025

my branch is probably super behind, too.

Yeah... I can resolve the conflicts if you'd like, it'll probably take me a little while because while you were gone we set up clang-format.

@centiweeger22
Copy link
Author

my branch is probably super behind, too.

Yeah... I can resolve the conflicts if you'd like, it'll probably take me a little while because while you were gone we set up clang-format.

Yeah, that would be nice, thanks. I'm gone again on vacation this time, so I guess I don't mind the wait.

@ErrorOliver2
Copy link
Contributor

i got a little question

by "just boxes" does it mean it could be boxes too if it weren't a line (like you filled that test sprite to not have a transparent filling)? would it like have a shaped outline thing and then boxes where the fill is?

should make merging way easier
@gradylink
Copy link
Member

OK, sorry I forgot about this, but I've started on conflict resolution.

@centiweeger22
Copy link
Author

i got a little question

by "just boxes" does it mean it could be boxes too if it weren't a line (like you filled that test sprite to not have a transparent filling)? would it like have a shaped outline thing and then boxes where the fill is?

nah right now it only supports the bitmap mode so it doesn't know lines from fills. it just makes the shape based on which pixels are filled in the image

@gradylink
Copy link
Member

gradylink commented Aug 25, 2025

I tried and failed to do the merge, there's just so much that changed, entire files got deleted.

EDIT: I got it closer with the clang-format change, but it's still a nearly 300 commit difference.

@centiweeger22
Copy link
Author

aw shoot, it might just be more worth it to just start over with the newer code. i haven't changed much so it would probably be pretty easy to get to the same point

@KirbySuper008
Copy link

I would absolutely recommend restarting. If you already know how you implemented it, it shouldn't be hard recreating it.

@gradylink
Copy link
Member

Since it looks like a new PR might be made (with code taken from this one), and do to the amount of conflicts i'm going to close this PR, feel free to ping me here or in the Discord if you would like this re-opened.

@gradylink gradylink closed this Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants