Fixes a crash with vanguard hashed sounds, as well as preventing a memory leak in GameBlackOps4.cpp (heap allocation never cleared)#51
Closed
echo000 wants to merge 3 commits intoScobalula:masterfrom
echo000:master
Closed
Fixes a crash with vanguard hashed sounds, as well as preventing a memory leak in GameBlackOps4.cpp (heap allocation never cleared)#51echo000 wants to merge 3 commits intoScobalula:masterfrom echo000:master
echo000 wants to merge 3 commits intoScobalula:masterfrom
echo000:master
Conversation
Fixes crash with vanguard hashed sounds
delete[] is never called for Decryption table, and is allocated to the heap, so will leak. Does not seem to be used outside of BlackOps4.cpp, removing the pointer, and instead allocating on the stack without the new keywork stops this memory leak and doesn't seem to break any of the functionality of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.