Skip to content

Added JSON_VALUE for mysql platform#122

Merged
Hikariii merged 2 commits intoScientaNL:masterfrom
Hikariii:mysql/json-value
Nov 8, 2024
Merged

Added JSON_VALUE for mysql platform#122
Hikariii merged 2 commits intoScientaNL:masterfrom
Hikariii:mysql/json-value

Conversation

@Hikariii
Copy link
Copy Markdown
Member

fixes #82

Copy link
Copy Markdown
Contributor

@annervisser annervisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means MariaDB will have JSON_VALUE twice

@Hikariii
Copy link
Copy Markdown
Member Author

Hikariii commented Oct 21, 2024

This means MariaDB will have JSON_VALUE twice

Available is imo the needed addition. It will be available twice. You still have to register every function separately, so they will not conflict if you pick what you need.

@annervisser
Copy link
Copy Markdown
Contributor

This means MariaDB will have JSON_VALUE twice

Available is imo the needed addition. It will be available twice. You still have to register every function separately, so they will not conflict if you pick what you need.

@Hikariii All other JSON functions in this repo's MySQL directory are also available (and identical) in MariaDB. It seems inconsistent to only have the JsonValue duplicated.

@Hikariii
Copy link
Copy Markdown
Member Author

Hikariii commented Nov 8, 2024

@annervisser I just updated json_value to be mysql specific.

@Hikariii Hikariii requested a review from annervisser November 8, 2024 10:37
Comment thread src/DBALCompatibility.php
@Hikariii Hikariii merged commit afb5d68 into ScientaNL:master Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON_VALUE also for MySQL?

4 participants