Harmonize label format and tick resolution choosing logic #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerkclark
commented
Aug 10, 2021
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 89.20% 90.58% +1.38%
==========================================
Files 1 1
Lines 176 170 -6
Branches 43 41 -2
==========================================
- Hits 157 154 -3
+ Misses 13 11 -2
+ Partials 6 5 -1
Continue to review full report at Codecov.
|
aulemahal
approved these changes
Aug 10, 2021
Contributor
aulemahal
left a comment
There was a problem hiding this comment.
This looks good, and more coherent! I see the potential issue with using a maybe-unset attribute from the other class, but let's leave that for another PR, when the issue comes up!
Member
Author
|
Thanks @aulemahal -- in it goes! |
This was referenced Aug 10, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
This takes a fairly simple approach to addressing #48. Here I define a mapping between the resolution chosen by the tick locator depending on the range and number of ticks requested, and the date format for the labels on the axis.
The plot @klindsay28's example now produces is shown below: