Fix NetCDFTimeConverter.convert with list #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 89.08% 89.20% +0.12%
==========================================
Files 1 1
Lines 174 176 +2
Branches 42 43 +1
==========================================
+ Hits 155 157 +2
Misses 13 13
Partials 6 6
Continue to review full report at Codecov.
|
Member
spencerkclark
left a comment
There was a problem hiding this comment.
Awesome, thanks @aulemahal. Just one minor nit, and perhaps could you also add a test similar to test_cftime_list_date that tests if a tuple of dates is passed to convert?
spencerkclark
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Fixes #47 and fixes #74. Now
NetCDFTimeConverter.convertaccepts lists or tuples, as given by matplotlib when usingfill_betweenandaxhspan(and maybe others).Added a unit test and an integration one.