Skip to content

Conversation

@bjlittle
Copy link
Member

@bjlittle bjlittle commented Apr 25, 2025

This pull-request bumps the minimum supported version to py311 and extends to py313.

The README.md now renders as follows:
image

@bjlittle bjlittle marked this pull request as draft April 25, 2025 14:41
@bjlittle bjlittle marked this pull request as ready for review April 25, 2025 15:38
@bjlittle bjlittle marked this pull request as draft April 25, 2025 17:04
@bjlittle bjlittle marked this pull request as ready for review April 25, 2025 23:51
@bjlittle
Copy link
Member Author

bjlittle commented Apr 25, 2025

Well, this PR has taken quite an unexpected turn ...

We require to control the build variant of py313 to ensure that it doesn't use the threaded no-GIL i.e., cp313t, as mo-pack doesn't compile against it.

To handle this elegantly I've opted to migrate to pixi, which is nothing short of stunning (that's pixi not me).

There is a lot to unpack (pun intended) in this PR for any reviewer unfamiliar with pixi, so that may require some discussion offline, which I'm more than happy to do 😄

Copy link
Contributor

@ukmo-ccbunney ukmo-ccbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of Pixi is very exciting here and does do a rather splendid job of making the build dependencies much clearer and more explicit. I like the use of the Pixi tooling to perform the build.

I guess we are making a decision here as to whether Pixi should be adopted (or start to be adopted) across the SciTools repositories. Personally, I think it is a great tool and will also be a nice replacement for tox/nox in other repos, so it get's my thumbs up. 👍

I'll wait until @stephenworsley adds his review comments as he might have some opinions on the adoption of Pixi (and deviating from the "norm" in the rest of SciTools?)

@stephenworsley
Copy link
Contributor

I'll wait until @stephenworsley adds his review comments as he might have some opinions on the adoption of Pixi (and deviating from the "norm" in the rest of SciTools?)

Everything I've seen of Pixi looks great so far, I think it's definitely worth giving it a spin here and seeing how it goes.

Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've been impressed by everything I've seen of Pixi so far so it will be good to try it out for this repo.

@ukmo-ccbunney ukmo-ccbunney merged commit 9410821 into SciTools:main Apr 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants