-
Notifications
You must be signed in to change notification settings - Fork 13
py312 minimum supported version #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Well, this PR has taken quite an unexpected turn ... We require to control the build variant of To handle this elegantly I've opted to migrate to pixi, which is nothing short of stunning (that's There is a lot to unpack (pun intended) in this PR for any reviewer unfamiliar with |
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of Pixi is very exciting here and does do a rather splendid job of making the build dependencies much clearer and more explicit. I like the use of the Pixi tooling to perform the build.
I guess we are making a decision here as to whether Pixi should be adopted (or start to be adopted) across the SciTools repositories. Personally, I think it is a great tool and will also be a nice replacement for tox/nox in other repos, so it get's my thumbs up. 👍
I'll wait until @stephenworsley adds his review comments as he might have some opinions on the adoption of Pixi (and deviating from the "norm" in the rest of SciTools?)
Everything I've seen of Pixi looks great so far, I think it's definitely worth giving it a spin here and seeing how it goes. |
stephenworsley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've been impressed by everything I've seen of Pixi so far so it will be good to try it out for this repo.
This pull-request bumps the minimum supported version to
py311and extends topy313.The

README.mdnow renders as follows: