Skip to content

Conversation

@pp-mo
Copy link
Member

@pp-mo pp-mo commented Dec 2, 2024

It seems that the only remaining problem for numpy2 is that the update to the code introduced here in #578 was causing tests to fail, when actually run with numpy 2.

I had meant to keep that issue separate from the eccodes 2v38 one, but somehow I tripped over my own commits.

This PR fixes that, so when merged it should unblock #550 🤞

@pp-mo pp-mo marked this pull request as draft December 2, 2024 18:13
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.61%. Comparing base (11169cf) to head (da4792b).
Report is 29 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #580   +/-   ##
=======================================
  Coverage   89.60%   89.61%           
=======================================
  Files           8        8           
  Lines        2473     2475    +2     
  Branches      420      420           
=======================================
+ Hits         2216     2218    +2     
  Misses        159      159           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pp-mo pp-mo marked this pull request as ready for review December 3, 2024 11:21
@pp-mo pp-mo requested a review from trexfeathers December 3, 2024 11:21
@trexfeathers
Copy link
Contributor

I tested this locally and it does indeed eliminate this error:

AssertionError: np.uint32(4294967295) != -1

But I still get these two errors:

TypeError: a class that defines __slots__ without defining __getstate__ cannot be pickled

@pp-mo
Copy link
Member Author

pp-mo commented Dec 12, 2024

But I still get these two errors:

TypeError: a class that defines __slots__ without defining __getstate__ cannot be pickled

Oh that's a bit weird : I didn't get that.
Also, I don't think that is a numpy2 thing, it's just generally a fact about pickling, so I can't see why anything here should be relevant to it, or the adoption of numpy2 for that matter.
So, where does this crop up ??

@trexfeathers
Copy link
Contributor

So, where does this crop up ??

It's in the failures for #550

@trexfeathers
Copy link
Contributor

But I still get these two errors:

TypeError: a class that defines __slots__ without defining __getstate__ cannot be pickled

This was proven to be caused by an unrelated Dask problem - SciTools/iris#6258

@trexfeathers trexfeathers merged commit 640ebf4 into SciTools:main Dec 16, 2024
10 checks passed
@pp-mo pp-mo deleted the np2_hindcast_fix branch April 2, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants