-
Notifications
You must be signed in to change notification settings - Fork 44
Initial upgrade to "Code QA Sprint" standards #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
=======================================
Coverage 89.60% 89.60%
=======================================
Files 8 8
Lines 2473 2473
Branches 420 420
=======================================
Hits 2216 2216
Misses 159 159
Partials 98 98 ☔ View full report in Codecov by Sentry. |
TODOHeads-up for what isn't here, to be addressed next (or ruled out-of-scope for the Code-QA sprint project) :
|
|
Fixed up to a point, probably a reasonable starting position. with the meanings
|
399a625 to
c163a8d
Compare
a1b8ab5 to
ef968a9
Compare
|
Rebased following update for dependabot changes. |
ef968a9 to
d6d581e
Compare
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes from this commit (d6d581e) all look very sensible. 👍
ukmo-ccbunney
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. 👍
Don't forget to raise an issue for the ignored mypy tests (there will probably be a lot more once [tool.mypy] strict = True?
0e2ea17 to
729ba13
Compare
|
Something odd here. I removed the temporary "Wild renames" commit from the branch on my fork, but Github doesn't pick up the 'backwards change', for some odd reason. So I closed, but now it won't allow re-open. Bear with while I try to sort it. |
Updated pre-commit config, to be compared with recommendations in "Scitools Code Quality Bonanza" project