Eccodes 2v36 #504
Merged
Eccodes 2v36 #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
==========================================
+ Coverage 89.13% 89.16% +0.02%
==========================================
Files 8 8
Lines 2467 2473 +6
Branches 418 420 +2
==========================================
+ Hits 2199 2205 +6
Misses 170 170
Partials 98 98 ☔ View full report in Codecov by Sentry. |
Member
Author
Contributor
trexfeathers
left a comment
There was a problem hiding this comment.
Thanks @pp-mo!
I used this for reference during my review: v2.36.0 release notes
trexfeathers
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for a couple of backwards-incompatibilities introduced in eccodes version 2.36
N.B. this also tested OK against 2.35, for which these lines are required.However, it's not clear how old an eccodes this will support, sinceindicatorOfUnitOfTimeRangeis only aliassed on loading -- not in saving, where setting it always+only usesindicatorOfUnitForForecastTime(the new form).From their release page, v2.33 is when
indicatorOfUnitForForecastTimewas introduced, which we now write on saves.Tested against eccodes v2.33 and v2.32 : confirmed the new code works with 2.33 but not 2.32.
As stated in whatsnew + updated requirements yml files.
N.B. the old name
indicatorOfUnitOfTimeRangeis still used in grib1 loading, because that still requires it(!yuck!)