adopt repo-review pre-commit hook #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
=======================================
Coverage 89.51% 89.51%
=======================================
Files 8 8
Lines 2450 2450
Branches 416 416
=======================================
Hits 2193 2193
Misses 161 161
Partials 96 96 ☔ View full report in Codecov by Sentry. |
bjlittle
commented
Apr 25, 2024
pp-mo
approved these changes
Apr 25, 2024
Member
pp-mo
left a comment
There was a problem hiding this comment.
Looks cool !
I assume the simple "sp-repo-review ... Passed" line in the pre-commit actions output is all the evidence I need that this is working as intended
Member
|
Oooh, I missed something ... |
Member
Author
|
That would be nice, but not that I know of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some exceptions to the rule (some of which we can address), but it's best that we adopt the
repo-reviewhook now to ensure that we don't regress.