Skip to content

Conversation

@ESadek-MO
Copy link
Contributor

Closes #340.
Finishes work started in #415.

@ESadek-MO ESadek-MO requested a review from bjlittle April 17, 2024 14:08
@ESadek-MO
Copy link
Contributor Author

Readded in a couple of links to be ignored:

https://software.ecmwf.int/ is no longer correct, https://confluence.ecmwf.int/ is, however it doesn't seem to have a landing page for GRIB.

I'm ignoring any errors in release notes atm, as it seems questionable to maintain that, but that might want to be discussed.

@ESadek-MO ESadek-MO marked this pull request as ready for review April 19, 2024 11:06
Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stephenworsley stephenworsley merged commit a9d45b1 into SciTools:main Apr 19, 2024
@ESadek-MO ESadek-MO deleted the linkchecks branch April 19, 2024 13:29
@bjlittle
Copy link
Member

@ESadek-MO @stephenworsley

The coverage is not completed nor working

@stephenworsley
Copy link
Contributor

@bjlittle Is it just not running in the CI at all then? I've had coverage problems in iris-esmf-regrid also, but they've been causing CI failures.

@bjlittle
Copy link
Member

Seems like the --coverage flag is passed into nox from the GHA, but then nothing is done with it.

@bjlittle
Copy link
Member

Also, if it was working, codecov would add comments to the pr.

I suspect tokens require to be also configured.

@stephenworsley
Copy link
Contributor

yeah, I suspect I'll need to sort out tokens for iris-esmf-regrid also

@pp-mo
Copy link
Member

pp-mo commented Apr 22, 2024

Also, if it was working, codecov would add comments to the pr.

I suspect tokens require to be also configured.

Not sure I follow exactly (I'm a bit rusty on this), but I think we can get around to this in due course.
@bjlittle @stephenworsley @ESadek-MO Can you please create a follow-on issue explaining what needs doing here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate from Cirrus CI to GitHub Actions

4 participants