-
Notifications
You must be signed in to change notification settings - Fork 44
Migrate to pytest #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to pytest #420
Conversation
pp-mo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally good with this !
Just one question : are the lockfiles re-resolved or manually edited ?
I can see they lose nose + gain a few new things, but no version change to existing packages. I guess that must be "ok", but possibly not optimal ?
stephenworsley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Awesome, thanks guys! 🥳 |
This pull-request migrates away from the home-brew
noserunner implementation topytest.Note that, the tests may be now run from the command line using
noxorpytest. However, when usingpytestfrom the CLI theirisenvironment variableOVERRIDE_TEST_DATA_REPOSITORYrequires to be also configured.I've not used the
pytest-xdistplugin, as I didn't deem it in scope ATM; the existing runtime of the tests is relatively short.In the future, we should look to use filterwarnings to control and manage the expected warnings raised during a test run.