Skip to content

NEP 29 changes - py39 minimum #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pp-mo merged 3 commits into from
Jul 6, 2023
Merged

NEP 29 changes - py39 minimum #339

pp-mo merged 3 commits into from
Jul 6, 2023

Conversation

@trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Jul 5, 2023

@trexfeathers
Copy link
Contributor Author

trexfeathers commented Jul 5, 2023

Updating the lock files seems to have brought along some minor printing changes affecting CML tests...

@trexfeathers trexfeathers mentioned this pull request Jul 5, 2023
Merged
@pp-mo
Copy link
Member

pp-mo commented Jul 5, 2023 •
edited
Loading

Updating the lock files seems to have brought along some minor printing changes affecting CML tests...

I don't think it is just numpy that changed.
I think that problem has been outstanding since #334, triggered by SciTools/iris#5235
At that time, we had a problem because iris-grib tests against both latest-main and latest-release Iris, and they had different behaviour.
But, since the changes have now appeared in a release, I think it should now be OK to update all the test results.
I was going to get around to it sometime, honest!

@trexfeathers
Copy link
Contributor Author

trexfeathers commented Jul 5, 2023

I've eyeballed the CML changes and they do seem to correspond to SciTools/iris#5235

@trexfeathers trexfeathers requested a review from pp-mo July 5, 2023 13:31
pp-mo
pp-mo approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK !

@pp-mo pp-mo merged commit 93eb3a2 into SciTools:main Jul 6, 2023
@trexfeathers
Copy link
Contributor Author

trexfeathers commented Jul 6, 2023

Thanks @pp-mo!

@trexfeathers trexfeathers mentioned this pull request Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pp-mo pp-mo pp-mo approved these changes

Assignees

No one assigned

Labels

Type: Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trexfeathers @pp-mo