Convert gribapi to eccodes #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbdreyer
requested changes
Mar 28, 2023
Member
lbdreyer
left a comment
There was a problem hiding this comment.
Thanks for doing this @s-boardman !
This has been on our to do list as I think it has confused developers who were unsure why we using gribapi when it had been deprecated!
Could you address the points I have raised below?
Co-authored-by: lbdreyer <lbdreyer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gribapi has been deprecated for a little while now and replaced by eccodes. There's a bit of guidance around the migration but its pretty much a find/replace of
gribapi->eccodesandgrib_->codes_.I've run the tests with the current version of iris-test-data and everything now passes.
There are a couple of references to early versions gribapi not handling certain use cases, but at the moment I've been unable to work out if they can be removed.