Correct bounded forecast period calculation #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbdreyer
approved these changes
Mar 15, 2023
Member
lbdreyer
left a comment
There was a problem hiding this comment.
This is brilliant! Thanks for your contribution @s-boardman !
What you have done with the testing is sufficient so I'm happy to just merge this in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #321 by correcting the calculation of the
periodinforecast_periodcoordinates with bounds. Currently the code tries to repeat a conversion of the values for the bounds into hours which results in an incorrect value. In addition the units of theforecast_periodcoordinate are not set tohourseven though the values are converted to hours.I suspect the testing I've done could be expanded / improved so I'm particularly keen for feedback which could help improve the coverage.