-
Notifications
You must be signed in to change notification settings - Fork 44
Add loading+saving for non-supported fixed surfaces #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pp-mo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I raised a couple of points, but admit I'm being quite fussy.
I think the code is good + testing coverage is excellent !
|
Regarding the failing tests, it seems clear that the test Checking what this used to do, it did not previously have the extra "unknown" coordinate. So, I guess this is intentional, but also it is a breaking change. |
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
I don't see this as a problem, and I don't agree that it is a breaking change. We are now supporting the loading of something that we previously were skipping. The old behaviour was just due to Iris-grib's limitations. This extends iris-grib's capability rather the changing it. From a user's perspective, it may have an impact on how their cubes get loaded (e.g. a GRIB file with multiple heights now may be merged into a 3D cube rather than a list of 2D slices) but I see this as us correcting the behaviour. |
👍 If you're confident to label this as a "fix", then I'm OK with it + it is not "breaking" ! |
|
Thanks @lbdreyer I think this is fine now. |
No description provided.