Transverse Mercator support negative scanning #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Have expanded the scope to support negative scanning in either direction, following conversation with @pp-mo. |
lbdreyer
reviewed
Apr 14, 2022
pp-mo
reviewed
Apr 22, 2022
pp-mo
requested changes
Apr 22, 2022
Member
pp-mo
left a comment
There was a problem hiding this comment.
I think the warning/error messages need to be clearer.
Otherwise OK now, I think.
pp-mo
approved these changes
Apr 25, 2022
Member
|
Thanks @trexfeathers ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have been able to confirm that this behaviour handles a file as expected, thanks to @MoseleyS and @edwardccsteele.