-
Notifications
You must be signed in to change notification settings - Fork 49
Bug with origin set to None after operation #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
==========================================
+ Coverage 57.58% 57.61% +0.03%
==========================================
Files 61 61
Lines 6292 6293 +1
Branches 1150 1150
==========================================
+ Hits 3623 3626 +3
+ Misses 2378 2376 -2
Partials 291 291 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
bjlittle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HGWright Awesome, looks good to me 😄
Just a few minor comments to service.
Could you also add some test coverage that proves pickling and unpickling of units in general and particularly after arithmetic now works 👍
Co-authored-by: Bill Little <bill.little@metoffice.gov.uk>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
bjlittle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Nice one 💯
🚀 Pull Request
Description
closes #582