Skip to content

Conversation

@HGWright
Copy link
Contributor

@HGWright HGWright commented Jul 4, 2025

🚀 Pull Request

Description

closes #582

@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.61%. Comparing base (feca87c) to head (d323253).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   57.58%   57.61%   +0.03%     
==========================================
  Files          61       61              
  Lines        6292     6293       +1     
  Branches     1150     1150              
==========================================
+ Hits         3623     3626       +3     
+ Misses       2378     2376       -2     
  Partials      291      291              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bjlittle bjlittle self-assigned this Jul 4, 2025
@bjlittle
Copy link
Member

bjlittle commented Jul 4, 2025

pre-commit.ci autofix

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HGWright Awesome, looks good to me 😄

Just a few minor comments to service.

Could you also add some test coverage that proves pickling and unpickling of units in general and particularly after arithmetic now works 👍

@HGWright
Copy link
Contributor Author

HGWright commented Jul 4, 2025

pre-commit.ci autofix

Copy link
Member

@bjlittle bjlittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Nice one 💯

@bjlittle bjlittle merged commit cfd64f8 into SciTools:main Jul 4, 2025
19 checks passed
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Pickle dump-load bug

2 participants